Re: [spi-devel-general] [PATCH] SST25L (non JEDEC) SPI Flash driver

Baruch Siach
2009-06-22T04:14:57Z

Hi Ryan,

On Mon, Jun 22, 2009 at 03:58:51PM +1200, Ryan Mallon wrote:
> +static int sst25l_erase_block(struct sst25l_flash *flash, u32 offset)
> +{
> + u8 command[4];
> + int err;
> +
> + err = sst25l_write_enable(flash, 1);

Is this enable/disable strictly required for each write/erase? Can't we just
enable write once?

> + if (err)
> + return err;
> +
> + command[0] = SST25L_CMD_BLOCK_ERASE;
> + command[1] = offset >> 16;
> + command[2] = offset >> 8;
> + command[3] = offset;
> + err = spi_write(flash->spi, command, 4);
> + if (err)
> + return err;
> +
> + err = sst25l_wait_till_ready(flash);
> + if (err)
> + return err;
> +
> + return sst25l_write_enable(flash, 0);
> +}

baruch

--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -