linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: David Brownell <david-b@pacbell.net>
Cc: tglx@linutronix.de, linux-mtd@lists.infradead.org
Subject: Re: [PATCH V5 1/2] mtd: nand: move layout structure into nand_ecc_ctrl
Date: Fri, 17 Jul 2009 13:20:38 -0700	[thread overview]
Message-ID: <4A60DD16.5070804@boundarydevices.com> (raw)
In-Reply-To: <200907171246.49342.david-b@pacbell.net>

David Brownell wrote:
> On Thursday 16 July 2009, Troy Kisky wrote:
>>                 case 2048:
>> -                       nand_chip->ecc.layout = &atmel_oobinfo_large;
>> +                       memcpy(&nand_chip->ecc.layout, &atmel_oobinfo_large,
>> +                                       sizeof(nand_chip->ecc.layout));
>>                         ecc_writel(host->ecc, MR, ATMEL_ECC_PAGESIZE_2112);
>>                         break;
> 
> Surely using structure assignment
> 
> 			nand_chip->ecc.layout = atmel_oobinfo_large;
> 
> would be better, everywhere?
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 
Certainly would be easier to understand, but I thought it would generate
larger code, no?


No problem to change, I will next round, unless someone objects.

Thanks for the review.
Troy

  reply	other threads:[~2009-07-17 20:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1247789948-5764-1-git-send-email-troy.kisky@boundarydevices.com>
2009-07-17 19:46 ` [PATCH V5 1/2] mtd: nand: move layout structure into nand_ecc_ctrl David Brownell
2009-07-17 20:20   ` Troy Kisky [this message]
2009-07-17 21:19     ` David Brownell
     [not found] ` <1247789948-5764-2-git-send-email-troy.kisky@boundarydevices.com>
2009-07-17  1:19   ` [PATCH V5 2/2] mtd: nand: Calculate better default ecc layout Troy Kisky
2009-07-23 19:14   ` Troy Kisky
2009-07-23 19:26     ` David Brownell
2009-07-23 19:38       ` Troy Kisky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A60DD16.5070804@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=david-b@pacbell.net \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).