Re: [PATCH] [mtd] fixed faulty check

Sebastian Andrzej Siewior
2009-07-30T13:03:51Z

Stoyan Gaydarov wrote:
> Resubmit of a patch with some additions, see http://lkml.org/lkml/2009/7/30/97
>
Please add a description of the path here. That's the place where people
are looking for them. The link might be a an additional reference.

> Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu>
> ---
> drivers/mtd/maps/physmap_of.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
> index 39d357b..e7ab5f0 100644
> --- a/drivers/mtd/maps/physmap_of.c
> +++ b/drivers/mtd/maps/physmap_of.c
> @@ -215,7 +215,8 @@ static int __devinit of_flash_probe(struct of_device *dev,
> goto err_out;
>
> mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
> - if (!info)
> + if (!mtd_list)
> + kfree(info);
> goto err_out;

This is not python, you have to be explicit about braces. Now your code
looks like this:

mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
if (!mtd_list)
kfree(info);
goto err_out;
>
> dev_set_drvdata(&dev->dev, info);

Sebastian