Re: nand_update_bbt fix

[Artem Bityutskiy <dedekind1@gmail.com>]

On 08/11/2009 07:03 PM, Andrew McKay wrote:
>>> out:
>>> - kfree(buf);
>>> + vfree(buf);
>>> return res;
>>> }
>>
>> I would disagree with this patch. Other people are fighting against
>> vmalloc, because they want to do DMA in their drivers, but they cannot.
>> I've CCed Zhang who is doing the opposite to what you do.
>
> I understand vmalloc is frowned upon in general, but then why is it
> already being used in nand_scan_bbt? Any fix that avoids vmalloc for
> nand_update_bbt should be used in nand_scan_bbt as well.

My position is:
   * vmalloc is a problem because it prevents DMA
   * kmalloc is a problem because large allocations of contiguous memory
     are impossible

Thus, I think people should invent some nice solution for the whole issue
instead of turning vmalloc's into kmallocks and back and forth. I'm CCing
David Brownell because AFAIR he was discussing similar things on lkml some
time ago.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)