From: Chris Moore <moore@free.fr>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Guillaume LECERF <glecerf@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v5 5/9] [MTD] remove bogus warning about missing boot bank location
Date: Fri, 14 May 2010 08:17:13 +0200 [thread overview]
Message-ID: <4BECEAE9.2030008@free.fr> (raw)
In-Reply-To: <1273796379.9999.509.camel@macbook.infradead.org>
Le 14/05/2010 02:19, David Woodhouse a écrit :
> On Sat, 2010-04-24 at 17:58 +0200, Guillaume LECERF wrote:
>
>> From: Uwe Kleine-König<Uwe.Kleine-Koenigi@digi.com>
>>
>> After the deleted block bootloc is only used once as follows:
>>
>> if (bootloc == 3&& something_else) {
>> ...
>>
>> So setting bootloc = 2 doesn't change anything. Taking that the
>> warning is wrong and missleading.
>>
>> Signed-off-by: Uwe Kleine-König<Uwe.Kleine-Koenig@digi.com>
>> Signed-off-by: Guillaume LECERF<glecerf@gmail.com>
>> Acked-by: Christopher Moore<moore@free.fr>
>>
> The warning should be preserved for invalid values, or values we don't
> support. I don't think it's correct to just remove it.
>
>
But, David, the only effect of this code is to print an *erroneous* message.
The message says "Assuming top" but sets bootloc to bottom (2) :(
See this thread: http://thread.gmane.org/gmane.linux.drivers.mtd/22176
Remark: this would be even clearer if the bootloc values were macros
instead of 2, 3, ...
If you really want to keep the message then it must at least be changed
to "Assuming bottom".
Cheers,
Chris
next prev parent reply other threads:[~2010-05-14 6:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 15:57 [PATCH v5 1/9] mtd: cfi_probe: enter Auto Select Mode after filling cfi->cfiq members Guillaume LECERF
2010-04-24 15:57 ` [PATCH v5 2/9] mtd: cfi_probe: make the addresses used to enter Auto Select Mode variable Guillaume LECERF
2010-04-24 15:58 ` [PATCH v5 3/9] mtd: cfi_probe: add support for SST 0x0701 vendorname Guillaume LECERF
2010-04-24 15:58 ` [PATCH v5 4/9] mtd: cfi_probe: use P_ID_* definitions instead of hardcoded values Guillaume LECERF
2010-04-24 15:58 ` [PATCH v5 5/9] [MTD] remove bogus warning about missing boot bank location Guillaume LECERF
2010-04-29 5:57 ` Artem Bityutskiy
2010-04-29 11:01 ` Guillaume LECERF
2010-05-11 8:43 ` Guillaume LECERF
2010-05-14 0:19 ` David Woodhouse
2010-05-14 6:17 ` Chris Moore [this message]
2010-05-14 7:54 ` David Woodhouse
2010-05-14 8:09 ` Guillaume LECERF
2010-05-14 8:15 ` David Woodhouse
2010-04-24 15:58 ` [PATCH v5 6/9] mtd: cfi_cmdset_0002: do not fail on no extended query table as they are both optional Guillaume LECERF
2010-04-24 15:58 ` [PATCH v5 7/9] mtd: cfi_cmdset_0002: add CFI detection for SST 39VF{16, 32}xx chips Guillaume LECERF
2010-04-24 15:58 ` [PATCH v5 8/9] mtd: cfi_cmdset_0002: add CFI detection for SST 39VF{32, 64}xxB chips Guillaume LECERF
2010-04-24 15:58 ` [PATCH v5 9/9] mtd: cfi_util: do not printk if no extended query table Guillaume LECERF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BECEAE9.2030008@free.fr \
--to=moore@free.fr \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=glecerf@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).