From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1OCsnV-0007C0-NR for linux-mtd@lists.infradead.org; Fri, 14 May 2010 11:11:18 +0000 Message-ID: <4BED2FD0.5010308@pengutronix.de> Date: Fri, 14 May 2010 13:11:12 +0200 From: Marc Kleine-Budde MIME-Version: 1.0 To: Haojian Zhuang Subject: Re: [PATCH 17/20] pxa3xx_nand: add cmdline part parser support References: <1273804364.9999.881.camel@macbook.infradead.org> <1273824971.9999.1582.camel@macbook.infradead.org> <20100514084149.GJ30801@buzzloop.caiaq.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB301CCC1222A518A8941748A" Cc: linux-arm-kernel , linux-mtd@lists.infradead.org, David Woodhouse , Eric Miao , Daniel Mack List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB301CCC1222A518A8941748A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Haojian Zhuang wrote: > On Fri, May 14, 2010 at 4:41 PM, Daniel Mack wrote: >> On Fri, May 14, 2010 at 09:16:11AM +0100, David Woodhouse wrote: >>> On Fri, 2010-05-14 at 14:08 +0800, Haojian Zhuang wrote: >>>> New patches are rebased for mtd-2.6 master branch. There're containe= d >>>> in another mail loop. >>> Hm, please test these by sending to yourself first, saving the patche= s >>> and checking that they apply. >>> >>> [dwmw2@macbook mtd-2.6]$ git describe HEAD >>> v2.6.34-rc7-142-gf6b173c >>> >>> [dwmw2@macbook mtd-2.6]$ for a in `seq -w 1 20` ; do echo Patch $a ; = patch -p1 < pxa$a.patch ; done >>> Patch 01 >>> patching file arch/arm/plat-pxa/include/plat/pxa3xx_nand.h >>> patching file drivers/mtd/nand/Kconfig >>> patching file drivers/mtd/nand/pxa3xx_nand.c >>> patch: **** malformed patch at line 203: transfering to/from NAND HW"= ); >> Jep, they're line-wrapped, just like the version before. >> >> Haojian, you can avoid this to happen by using 'git send-email'. >> >> Thanks, >> Daniel >> >=20 > Now I attach these patches directly. Only 0011 patch is changed to > using dev_dbg for debug print. I NACK patches 1 and 17. See my reply to these individual patches. Cheers, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enigB301CCC1222A518A8941748A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkvtL9AACgkQjTAFq1RaXHOdtwCeMtGKgHVigT4urWbKqsW5kN3P ZaUAn2/3KLZFDCidgrjtyN5ZvcjwAPfs =wP6l -----END PGP SIGNATURE----- --------------enigB301CCC1222A518A8941748A--