From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bld-mail15.adl6.internode.on.net ([150.101.137.100] helo=mail.internode.on.net) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OTUbC-0001Y6-GU for linux-mtd@lists.infradead.org; Tue, 29 Jun 2010 06:47:16 +0000 Message-ID: <4C2996E7.9040209@elphinstone.net> Date: Tue, 29 Jun 2010 16:47:03 +1000 From: Mark Ware MIME-Version: 1.0 To: dedekind1@gmail.com Subject: Re: [RFC/PATCH] doc2000: Fix uninitialized variable in doc_ecc_decode() References: <4BFDCEC3.7070601@elphinstone.net> <1277792986.1041.959.camel@localhost> In-Reply-To: <1277792986.1041.959.camel@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Thomas Gleixner , linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 29/06/10 16:29, Artem Bityutskiy wrote: > On Thu, 2010-05-27 at 11:45 +1000, Mark Ware wrote: >> The variable 'syn' was being used uninitialized. Also >> fixed incorrect use of syn[] vs s[]. >> >> Tested on powerpc board with 64MB DOC2000. >> --- >> >> I am porting from a 2.4.18 kernel to 2.6.32, and I saw random media header >> mismatches causing a failure to detect the DOC device partitions. Tracing >> through, I saw this variable being used uninitialized and I suspect >> incorrectly also. >> >> I do not really understand how the ecc/syndrome code works, so I do not >> know if this patch is the correct solution, but it did make my problem >> go away... >> >> CC: Thomas Gleixner as I believe he may have written this function initially. > > Please, always add Signed-off-by for kernel patches. I added it for you. > Thanks. I guess I expected to be told that I was smoking something and that my DOC error disappearing was unrelated... Mark