From: "stanley.miao" <stanley.miao@windriver.com>
To: Artem.Bityutskiy@nokia.com
Cc: linux-mtd@lists.infradead.org, joakim.tjernlund@transmode.se
Subject: Re: [PATCH v3] Fix mtd-utils bugs
Date: Wed, 04 Aug 2010 15:33:53 +0800 [thread overview]
Message-ID: <4C5917E1.8070704@windriver.com> (raw)
In-Reply-To: <1280905473.15689.68.camel@localhost>
Sorry for taking so long time. I am busy with our project recently.
I have seen you merged Kavin's patches. I will read them and add my
patches based
on them as soon as possible.
Stanley.
Artem Bityutskiy wrote:
> On Sun, 2010-07-18 at 11:40 +0300, Artem Bityutskiy wrote:
>
>> On Sun, 2010-06-20 at 20:22 +0800, Stanley.Miao wrote:
>>
>>> Changes from V2:
>>> 1, Get the linux version via uname() according to Joakim Tjernlund.
>>> 2, Set the default version the latest version according to Joakim Tjernlund.
>>>
>>> The "struct nand_oobinfo" is able to record only 32 ECC code positions,which
>>> is not enough for many big NAND chips. Therefore, this structure is replaced
>>> by "struct nand_ecclayout" in linux kernel from the version 2.6.17.
>>> Consequently, the ioctl command changed from MEMGETOOBSEL to ECCGETLAYOUT.
>>>
>>> Now update nandwrite to use the new ioctl command ECCGETLAYOUT. In order to
>>> keep compatible with the old linux kernel, a linux version detection function
>>> is added.
>>>
>>> YAFFS and JFFS2 has updated and we don't need the arguments "forcelegacy",
>>> "forcejffs2", "forceyaffs" anymore. Now clean them up.
>>>
>> Stanley, sorry that this all takes so long time, I do not have enough
>> time. Basically, Kevin's patches are almost there, I sent him 2 other
>> patches, as soon as he reviews them, they should go in. Then you can
>> start using libmtd for your purposes as well. You'll need to extend it a
>> bit, though.
>>
>> Vs. uname() - I do not really like this idea, because kernel version
>> does not cover the case when ECCGETLAYOUT is back-ported to older
>> kernels.
>>
>> Try to use similar technique as Kevin used - just call ECCGETLAYOUT
>> ioctl, and if it returns ENOTTY, this ioctl is not supported. See also
>> offs64_ioctl flag handling in my patches to Kevin (sent 1 yesterday, and
>> 1 today).
>>
>
> Just a reminder than now we have Kevin's patches in and you can do your
> things on top.
>
>
next prev parent reply other threads:[~2010-08-04 7:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 12:22 [PATCH v3] Fix mtd-utils bugs Stanley.Miao
2010-06-20 12:22 ` [PATCHv3 1/3] clean up the legacy interfaces in nandwrite.c Stanley.Miao
2010-06-20 12:22 ` [PATCHv3 2/3] Discard the legacy interface MEMGETOOBSEL in flash_eraseall Stanley.Miao
2010-06-20 12:23 ` [PATCHv3 3/3] Place the cleanmarker in OOB area according to the mode MTD_OOB_AUTO Stanley.Miao
2010-06-22 8:35 ` [PATCH v3] Fix mtd-utils bugs stanley.miao
2010-06-23 13:18 ` Artem Bityutskiy
2010-06-23 15:16 ` Ladislav Michl
2010-08-20 5:29 ` Artem Bityutskiy
2010-08-20 13:03 ` Ladislav Michl
2010-08-30 10:42 ` Artem Bityutskiy
2010-07-08 6:47 ` Artem Bityutskiy
2010-07-08 7:10 ` stanley.miao
2010-07-18 8:40 ` Artem Bityutskiy
2010-08-04 7:04 ` Artem Bityutskiy
2010-08-04 7:33 ` stanley.miao [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-18 10:32 Stanley.Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5917E1.8070704@windriver.com \
--to=stanley.miao@windriver.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).