Re: [PATCH 2/3] mtd: m25p80: add support for the Intel/Numonyx {16, 32, 64}0S33B SPI flash chips

Re: [PATCH 2/3] mtd: m25p80: add support for the Intel/Numonyx {16, 32, 64}0S33B SPI flash chips

[Gabor Juhos]

2010.08.05. 15:19 keltezéssel, Luigi Zambrano írta:

> Actually I’m not sure about this patch. From the datasheet, the 16Mbit
> device has 32 sectors (32*64KB = 16Mbit), the 32Mbit device has 64 sectors
> (64*64KB = 32Mbit) and the 64Mbit device has 128 sectors (128*64KB =
> 64Mbit). So, I think the patch has to be modified in the following way
> 
> 
> 
>  +       { "160s33b",  INFO(0x898911, 0, 64 * 1024,  32, 0) },
> 
>  +       { "320s33b",  INFO(0x898912, 0, 64 * 1024,  64, 0) },
> 
>  +       { "640s33b",  INFO(0x898913, 0, 64 * 1024, 128, 0) },
> 

Oops, you are right. We are using this patch in OpenWrt since a year or so, but
nobody noticed this so far. Good catch, thanks!

I will send a fixed version.

Regards,
Gabor

[PATCH 1/3] mtd: m25p80: add support for the EON EN25P{32, 64} SPI flash chips

[Gabor Juhos]

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
---
 drivers/mtd/devices/m25p80.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 48bf325..21d866c 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -641,6 +641,10 @@ static const struct spi_device_id m25p_ids[] = {
 	{ "at26df161a", INFO(0x1f4601, 0, 64 * 1024, 32, SECT_4K) },
 	{ "at26df321",  INFO(0x1f4701, 0, 64 * 1024, 64, SECT_4K) },
 
+	/* EON -- en25pxx */
+	{ "en25p32", INFO(0x1c2016, 0, 64 * 1024,  64, 0) },
+	{ "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
+
 	/* Macronix */
 	{ "mx25l4005a",  INFO(0xc22013, 0, 64 * 1024,   8, SECT_4K) },
 	{ "mx25l8005",   INFO(0xc22014, 0, 64 * 1024,  16, 0) },
-- 
1.5.3.2

[PATCH 2/3] mtd: m25p80: add support for the Intel/Numonyx {16, 32, 64}0S33B SPI flash chips

[Gabor Juhos]

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
---
 drivers/mtd/devices/m25p80.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 21d866c..57fec6d 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -645,6 +645,11 @@ static const struct spi_device_id m25p_ids[] = {
 	{ "en25p32", INFO(0x1c2016, 0, 64 * 1024,  64, 0) },
 	{ "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
 
+	/* Intel/Numonyx -- xxxs33b */
+	{ "160s33b",  INFO(0x898911, 0, 64 * 1024,  64, 0) },
+	{ "320s33b",  INFO(0x898912, 0, 64 * 1024, 128, 0) },
+	{ "640s33b",  INFO(0x898913, 0, 64 * 1024, 256, 0) },
+
 	/* Macronix */
 	{ "mx25l4005a",  INFO(0xc22013, 0, 64 * 1024,   8, SECT_4K) },
 	{ "mx25l8005",   INFO(0xc22014, 0, 64 * 1024,  16, 0) },
@@ -834,11 +839,12 @@ static int __devinit m25p_probe(struct spi_device *spi)
 	dev_set_drvdata(&spi->dev, flash);
 
 	/*
-	 * Atmel and SST serial flash tend to power
+	 * Atmel, SST and Intel/Numonyx serial flash tend to power
 	 * up with the software protection bits set
 	 */
 
 	if (info->jedec_id >> 16 == 0x1f ||
+	    info->jedec_id >> 16 == 0x89 ||
 	    info->jedec_id >> 16 == 0xbf) {
 		write_enable(flash);
 		write_sr(flash, 0);
-- 
1.5.3.2