From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4C5F9715.1030806@snapgear.com> Date: Mon, 9 Aug 2010 15:50:13 +1000 From: Greg Ungerer MIME-Version: 1.0 To: Christian Dietrich Subject: Re: [PATCH 0/9] Removing dead code References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: Roman Zippel , John Stultz , Dominik Brodowski , linux-kernel@vger.kernel.org, Grant Likely , Alexander Kurz , linux-mtd@lists.infradead.org, Michael Roth , Greg Ungerer , Christoph Hellwig , Finn Thain , Tony Lindgren , vamos-dev@i4.informatik.uni-erlangen.de, Geert Uytterhoeven , Lennart Sorensen , Russell King , Anatolij Gustschin , Sam Creasey , linux-pcmcia@lists.infradead.org, Mike Frysinger , Sean MacLennan , Joe Perches , linux-m68k@lists.linux-m68k.org, Maxim Kuvyrkov , Thomas Gleixner , Jiri Kosina , Greg Kroah-Hartman , Wolfram Sang , Ralf Baechle , Martin Schwidefsky , Manuel Lauss , Andrew Morton , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Christian, Christian Dietrich wrote: > As part of the VAMOS[0] research project at the University of > Erlangen we are looking at multiple integrity errors in linux' > configuration system. > > I've been running a check on the arch/m68k{,nommu} sourcetree for > config Items not defined in Kconfig and found 9 such cases. Sourcecode > blocks depending on these Items are not reachable from a vanilla > kernel -- dead code. I've seen such dead blocks made on purpose > e.g. while integrating new features into the kernel but generally > they're just useless. > > Each of the patches in this patchset removes on such dead > config Item, I'd be glad if you consider applying them. I've been > doing deeper analysis of such issues before and can do so again but > I'm not so sure they were fastly usefull. > > In lack of an m68k cross compiler i was not able to build the kernel > against this patches. I don't think that they will crash the > compiling, but i'm not totally sure. > > Please keep me informed of this patch getting confirmed / > merged so we can keep track of it. I don't have any problems with any of these from a m68knommu point of view. I can merge them via the m68knommu git tree if you want? Regards Greg > [0] http://vamos1.informatik.uni-erlangen.de/ > > Christian Dietrich (9): > arch/m68k: Removing dead GG2 config option > arch/m68k: Removing dead BSEIP config option > arch/m68k{,nommu}: Removing dead SMP config option > Removing dead CONFIG_RPX(LITE|CLASSIC) > arch/m68knommu: Removing dead M68000 config option > arch/m68knommu: Removing dead RELOCATE config option > arch/m68knommu: Removing dead M68KFPU_EMU config option > arch/m68knommu: Removing dead RAM_{16,32}_MB config option > arch/m68knommu: Removing dead 68328_SERIAL_UART2 config option > > arch/m68k/Kconfig | 4 +- > arch/m68k/include/asm/amigahw.h | 1 - > arch/m68k/include/asm/commproc.h | 39 -------------- > arch/m68k/include/asm/io_mm.h | 37 -------------- > arch/m68k/include/asm/system_mm.h | 2 - > arch/m68k/include/asm/system_no.h | 9 --- > arch/m68k/kernel/setup.c | 6 -- > arch/m68k/kernel/time.c | 2 - > arch/m68k/sun3/sun3ints.c | 8 +-- > arch/m68knommu/kernel/ptrace.c | 18 ------- > arch/m68knommu/kernel/setup.c | 3 - > arch/m68knommu/kernel/time.c | 3 +- > arch/m68knommu/kernel/traps.c | 13 ----- > arch/m68knommu/platform/68328/head-de2.S | 6 -- > arch/m68knommu/platform/68328/head-ram.S | 27 ---------- > arch/m68knommu/platform/68VZ328/config.c | 5 -- > drivers/mtd/maps/Kconfig | 10 ---- > drivers/mtd/maps/Makefile | 1 - > drivers/mtd/maps/rpxlite.c | 64 ----------------------- > drivers/pcmcia/m8xx_pcmcia.c | 81 ------------------------------ > drivers/serial/68328serial.h | 5 -- > 21 files changed, 6 insertions(+), 338 deletions(-) > delete mode 100644 drivers/mtd/maps/rpxlite.c > > -- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com