From: "Brian Norris" <norris@broadcom.com>
To: "Tilman Sauerbeck" <tilman@code-monkey.de>
Cc: r64343@freescale.com, Kevin Cernekee <cernekee@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: Bad assumption about ID field definition for Samsung NAND?
Date: Fri, 20 Aug 2010 10:42:40 -0700 [thread overview]
Message-ID: <4C6EBE90.2090604@broadcom.com> (raw)
In-Reply-To: <20100820134316.GA437@code-monkey.de>
On 08/20/2010 06:43 AM, Tilman Sauerbeck wrote:
> Okay, how do we proceed? Should I send a proper patch with the diff
> above? Or does anyone want to try and come up with a better fix...?
I vote for Tilman's patch. There's nothing unnecessarily ugly about it;
it simply checks cell-type in order to decide whether we use Samsung's
new "standard" for MLC or fall-back to the real standard. If anything,
the existing code (checking ID length) is ugly. However, both checks
seem necessary.
Brian
next prev parent reply other threads:[~2010-08-20 17:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 18:05 Bad assumption about ID field definition for Samsung NAND? Tilman Sauerbeck
2010-08-18 23:25 ` Brian Norris
2010-08-19 17:16 ` Tilman Sauerbeck
2010-08-19 19:46 ` Kevin Cernekee
2010-08-19 22:28 ` Brian Norris
2010-08-20 3:29 ` Kevin Cernekee
2010-08-20 5:38 ` Liu Hui-R64343
2010-08-20 13:43 ` Tilman Sauerbeck
2010-08-20 17:42 ` Brian Norris [this message]
2010-08-20 19:53 ` David Woodhouse
2010-08-20 20:51 ` Tilman Sauerbeck
2010-08-20 21:01 ` Brian Norris
2010-08-20 21:34 ` David Woodhouse
2010-08-20 22:05 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6EBE90.2090604@broadcom.com \
--to=norris@broadcom.com \
--cc=cernekee@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=r64343@freescale.com \
--cc=tilman@code-monkey.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).