* [PATCH] nanddump: Fix hexdump nybble ordering
@ 2010-08-20 8:11 Jon Povey
2010-08-20 19:03 ` Brian Norris
2010-08-30 10:39 ` Artem Bityutskiy
0 siblings, 2 replies; 4+ messages in thread
From: Jon Povey @ 2010-08-20 8:11 UTC (permalink / raw)
To: linux-mtd; +Cc: Jon Povey, Brian Norris
Hex dumps were being printed with the nybbles reversed since
commit 6ff458433ba15b8a7cb258ce64e64e98982df26e
Fix.
Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk>
CC: Brian Norris <norris@broadcom.com>
---
nanddump.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/nanddump.c b/nanddump.c
index acfdb33..22fec5f 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -239,8 +239,8 @@ static void pretty_dump_to_buffer(const unsigned char *buf, size_t len,
for (j = 0; (j < len) && (lx + 3) <= linebuflen; j++) {
ch = buf[j];
- linebuf[lx++] = hex_asc[ch & 0x0f];
linebuf[lx++] = hex_asc[(ch & 0xf0) >> 4];
+ linebuf[lx++] = hex_asc[ch & 0x0f];
linebuf[lx++] = ' ';
}
if (j)
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nanddump: Fix hexdump nybble ordering
2010-08-20 8:11 [PATCH] nanddump: Fix hexdump nybble ordering Jon Povey
@ 2010-08-20 19:03 ` Brian Norris
2010-08-30 10:38 ` Artem Bityutskiy
2010-08-30 10:39 ` Artem Bityutskiy
1 sibling, 1 reply; 4+ messages in thread
From: Brian Norris @ 2010-08-20 19:03 UTC (permalink / raw)
To: Jon Povey; +Cc: linux-mtd@lists.infradead.org
On 08/20/2010 01:11 AM, Jon Povey wrote:
> Hex dumps were being printed with the nybbles reversed since
> commit 6ff458433ba15b8a7cb258ce64e64e98982df26e
> Fix.
Haha, wow. I'm pretty sure that when porting the kernel function over, I
noticed that, then promptly ignored it. Good catch!
Thanks,
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nanddump: Fix hexdump nybble ordering
2010-08-20 19:03 ` Brian Norris
@ 2010-08-30 10:38 ` Artem Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-08-30 10:38 UTC (permalink / raw)
To: Brian Norris; +Cc: Jon Povey, linux-mtd@lists.infradead.org
On Fri, 2010-08-20 at 12:03 -0700, Brian Norris wrote:
> On 08/20/2010 01:11 AM, Jon Povey wrote:
> > Hex dumps were being printed with the nybbles reversed since
> > commit 6ff458433ba15b8a7cb258ce64e64e98982df26e
> > Fix.
>
> Haha, wow. I'm pretty sure that when porting the kernel function over, I
> noticed that, then promptly ignored it. Good catch!
Just FYI, if you approve a patch, it is good to send Acked-by line which
I can copy-paste.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nanddump: Fix hexdump nybble ordering
2010-08-20 8:11 [PATCH] nanddump: Fix hexdump nybble ordering Jon Povey
2010-08-20 19:03 ` Brian Norris
@ 2010-08-30 10:39 ` Artem Bityutskiy
1 sibling, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2010-08-30 10:39 UTC (permalink / raw)
To: Jon Povey; +Cc: linux-mtd, Brian Norris
On Fri, 2010-08-20 at 17:11 +0900, Jon Povey wrote:
> Hex dumps were being printed with the nybbles reversed since
> commit 6ff458433ba15b8a7cb258ce64e64e98982df26e
> Fix.
>
> Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk>
> CC: Brian Norris <norris@broadcom.com>
> ---
> nanddump.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Pushed, thank you!
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-30 10:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-20 8:11 [PATCH] nanddump: Fix hexdump nybble ordering Jon Povey
2010-08-20 19:03 ` Brian Norris
2010-08-30 10:38 ` Artem Bityutskiy
2010-08-30 10:39 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).