linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Armando Visconti <armando.visconti@st.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Pratyush ANAND <pratyush.anand@st.com>,
	Viresh KUMAR <viresh.kumar@st.com>,
	Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
	Bhupesh SHARMA <bhupesh.sharma@st.com>,
	Sebastian RASMUSSEN <sebastian.rasmussen@stericsson.com>,
	Alessandro Rubini <rubini-list@gnudd.com>,
	Vipin KUMAR <vipin.kumar@st.com>,
	Shiraz HASHIM <shiraz.hashim@st.com>,
	Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Deepak SIKRI <deepak.sikri@st.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 27/74] ST SPEAr : NAND interface driver for spear platforms
Date: Thu, 2 Sep 2010 14:33:23 +0200	[thread overview]
Message-ID: <4C7F9993.3040700@st.com> (raw)
In-Reply-To: <AANLkTikwjCh=2Cekg9R1SqacKXC+_ZgV7m+=ZVVCaDba@mail.gmail.com>

Linus Walleij wrote:
> 2010/9/2 Armando Visconti <armando.visconti@st.com>:
>
>   
>>> I *highly* suspect that this driver duplicates some code found in
>>> drivers/mtd/nand/nomadik_nand.c because it's the same silicon.
>>>       
>> Why nomadik_nand.c?
>> Shouldn't the fsmc_nand.c rule apply also in this case?
>>     
>
> As I said I think nomadik_nand.c shall be deleted and replaced with
> this driver.
>
> Unless Alessandro hits me on the fingers... If it is made generic
> I can provide testing for the U300. (Maybe I can get my NHK8815
> card booting too, I don't know.)
>   
As I said before, the SPEAr driver should work on Nomadik too
as it looks generic enough and for us it is working
on two different platforms with different FSMC versions.

This, unless the Nomadik FSMC is a customized h/w block, which
I seem to remember in fact ...

Ciao,
Arm


-- 
-- "Every step appears to be the unavoidable consequence of the
-- preceding one." (A. Einstein) 
-- 
Armando Visconti                  Mobile: (+39) 346 8879146
Senior SW Engineer                Fax:    (+39) 02 93519290
CPG                               Work:   (+39) 02 93519683
Computer System Division          e-mail: armando.visconti@st.com
ST Microelectronics               TINA:   051  4683
                                    
 

  reply	other threads:[~2010-09-02 12:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1283161023.git.viresh.kumar@st.com>
2010-08-30 10:43 ` [PATCH 24/74] ST SPEAr: Add smi driver for serial NOR flash Viresh KUMAR
2010-08-30 10:43 ` [PATCH 27/74] ST SPEAr : NAND interface driver for spear platforms Viresh KUMAR
2010-09-01 22:36   ` Linus Walleij
2010-09-02  8:09     ` Armando Visconti
2010-09-02  8:52       ` Armando Visconti
2010-09-02 11:15       ` Linus Walleij
2010-09-02 12:33         ` Armando Visconti [this message]
2010-09-03 11:23           ` Alessandro Rubini
2010-09-03 17:26             ` Linus Walleij
2010-09-06  7:25               ` Armando Visconti
2010-09-10  4:21               ` viresh kumar
2010-09-10  8:38                 ` Linus Walleij
2010-09-03  7:11       ` Vipin Kumar
2010-09-03 11:22         ` Sebastian RASMUSSEN
2010-08-30 10:43 ` [PATCH 28/74] Incrementing the ecc_pos array to contain 128 char Viresh KUMAR
2010-08-30 12:14   ` Artem Bityutskiy
2010-08-31  6:34     ` Vipin Kumar
2010-08-31 23:36       ` Artem Bityutskiy
2010-09-01  4:13         ` Vipin Kumar
2010-09-01 10:45           ` Artem Bityutskiy
2010-09-01 11:04             ` Vipin Kumar
2010-09-01 21:23               ` Ryan Mallon
2010-09-01 21:54                 ` Kevin Cernekee
2010-09-01 22:21                   ` Ryan Mallon
2010-09-01 22:53                     ` Artem Bityutskiy
2010-09-01 23:37                       ` Ryan Mallon
2010-09-01 23:43                         ` Ryan Mallon
2010-09-02  6:33                     ` Brian Norris
2010-09-02  9:49                       ` Artem Bityutskiy
2010-09-01 23:23               ` Artem Bityutskiy
2010-08-30 10:43 ` [PATCH 29/74] Newly erased page read workaround Viresh KUMAR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7F9993.3040700@st.com \
    --to=armando.visconti@st.com \
    --cc=bhupesh.sharma@st.com \
    --cc=deepak.sikri@st.com \
    --cc=dwmw2@infradead.org \
    --cc=linus.ml.walleij@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pratyush.anand@st.com \
    --cc=rajeev-dlh.kumar@st.com \
    --cc=rubini-list@gnudd.com \
    --cc=sebastian.rasmussen@stericsson.com \
    --cc=shiraz.hashim@st.com \
    --cc=vipin.kumar@st.com \
    --cc=vipulkumar.samar@st.com \
    --cc=viresh.kumar@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).