From: Adrian Hunter <adrian.hunter@nokia.com>
To: "dedekind1@gmail.com" <dedekind1@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Arno Steffen <arno.steffen@googlemail.com>
Subject: Re: NOTE! mkfs.ubifs
Date: Tue, 07 Sep 2010 13:23:53 +0300 [thread overview]
Message-ID: <4C8612B9.4060305@nokia.com> (raw)
In-Reply-To: <1283850698.2979.25.camel@localhost>
Artem Bityutskiy wrote:
> On Tue, 2010-09-07 at 11:36 +0300, Artem Bityutskiy wrote:
>> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>>
>> When mkfs.ubifs is used with -r dir, it does not make the root UBIFS
>> inode uid/gid/permissions to be equivalent to dir's permissions, but
>> it makes root inode permissions to be equivalent to uid = git = 0
>> (root) and permissions = u+rwx go+rx.
>>
>> This patch changes the behavior and makes mkfs.ubifs use the
>> permissions of the directory containing the original files on the host.
>> I.e., it will be <dir>'s uid/git/permissions if case of mkfs.ubifs
>> -r <dir>.
>>
>> This patch is a bit dangerous because it changes the behavior and may
>> have security implications if someone used the older version, relied
>> on this bug, and upgrades to the newer version.
>>
>> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> All mkfs.ubifs users should take a look at this - should we apply this
> patch? I'm still in doubt...
>
I do not agree with changing the behaviour. It should be a new option,
and you could add a warning explaining what the root inode permissions
are and why e.g.
Warning: Option ?? not used. Setting root inode permissions to blah
Warning: Option ?? used. Setting root inode permissions to blah
next prev parent reply other threads:[~2010-09-07 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 8:36 [PATCH] mkfs.ubifs: do not override root inode permissions Artem Bityutskiy
2010-09-07 9:11 ` NOTE! mkfs.ubifs Artem Bityutskiy
2010-09-07 10:23 ` Adrian Hunter [this message]
2010-09-08 5:55 ` Artem Bityutskiy
2010-09-08 8:18 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8612B9.4060305@nokia.com \
--to=adrian.hunter@nokia.com \
--cc=arno.steffen@googlemail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).