From: Matthieu CASTET <matthieu.castet@parrot.com>
To: "dedekind1@gmail.com" <dedekind1@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: ubifs : corruption after power cut test
Date: Thu, 9 Sep 2010 11:22:49 +0200 [thread overview]
Message-ID: <4C88A769.4010103@parrot.com> (raw)
In-Reply-To: <1283763308.11066.0.camel@localhost>
Artem Bityutskiy a écrit :
> On Sun, 2010-08-22 at 10:44 +0300, Artem Bityutskiy wrote:
>> On Wed, 2010-07-28 at 09:40 +0200, Matthieu CASTET wrote:
>>> I manage to reproduce it with the backtrace [1].
>> Matthieu, your work-around patch or something very close should
>> certainly be applied to the UBIFS tree, but I still would like to find
>> out what exactly happened in your setup.
>>
>> I see 2 possibilities:
>>
>> 1. An error happened and 'ubifs_garbage_collect()' returned while
>> c->gc_lnum was -1. But in this case we should have switched to R/O mode,
>> and the master node would not be written. But may be for some reasons we
>> did not switch to R/O mode, dunno.
>>
>> 2. More likely scenario: in 'ubifs_rcvry_gc_commit()' we call
>> 'ubifs_garbage_collect_leb()' directly, which can return while
>> c->gc_lnum is -1. And we do not handle this.
>>
>> Would you please be patient enough to reproduce the issue once again with
>> the following patch, which was created against the latest ubifs-2.6.git, but
>> you should be easily able to apply it to your tree.
>
> Hi, any news?
>
Not much, I was busy on another subject but I will try ASAP.
Matthieu
PS : any idea/comment on the handling of interrupted write page by
UBI/UBIFS ?
next prev parent reply other threads:[~2010-09-09 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 12:04 ubifs : corruption after power cut test Matthieu CASTET
2010-07-13 7:27 ` Matthieu CASTET
2010-07-13 8:43 ` Matthieu CASTET
2010-07-13 9:24 ` Matthieu CASTET
2010-07-13 14:24 ` Artem Bityutskiy
2010-07-13 15:10 ` Matthieu CASTET
2010-07-28 7:40 ` Matthieu CASTET
2010-08-02 9:32 ` Matthieu CASTET
2010-08-04 16:14 ` Artem Bityutskiy
2010-08-22 7:44 ` Artem Bityutskiy
2010-09-06 8:55 ` Artem Bityutskiy
2010-09-09 9:22 ` Matthieu CASTET [this message]
2010-09-09 9:51 ` Artem Bityutskiy
2010-09-24 15:31 ` Matthieu CASTET
2010-09-24 16:50 ` Artem Bityutskiy
2010-07-13 11:07 ` Artem Bityutskiy
2010-07-13 12:06 ` Matthieu CASTET
2010-07-13 14:13 ` Artem Bityutskiy
2010-07-13 14:33 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C88A769.4010103@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).