From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: Aleksey Makarov <amakarov@ru.mvista.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Dharmappa, Savinay" <savinay.dharmappa@ti.com>,
David Griego <dgriego@mvista.com>
Subject: Re: [PATCH 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver
Date: Fri, 08 Oct 2010 13:56:47 +0400 [thread overview]
Message-ID: <4CAEEADF.5070103@mvista.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59302342ADE9D@dbde02.ent.ti.com>
Hello.
On 08-10-2010 8:54, Nori, Sekhar wrote:
>>> +static void da830_evm_nor_done(void *data)
>>> +{
>>> + clk_disable(da830_evm_nor.clk);
>>> + clk_put(da830_evm_nor.clk);
>>> + iounmap(da830_evm_nor.latch.addr);
>>> + release_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE);
>>> + iounmap(da830_evm_nor.aemif.addr);
>>> + release_mem_region(DA8XX_AEMIF_CTL_BASE, SZ_32K);
>>> +}
>> Why you've changed this function which was useful also for the error cleanup
>> before?
> The issues down below aside, I think goto based error handling
> is clearer to follow. Any objections to using goto based
> error handing per-se?
I think the code was more compact with the old error handling. And anyway,
I'm not feeling happy when TI is changing MV's code.
> Thanks,
> Sekhar
WBR, Sergei
next prev parent reply other threads:[~2010-10-08 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 11:34 [PATCH 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver Savinay Dharmappa
2010-10-07 15:05 ` Sergei Shtylyov
2010-10-08 4:54 ` Nori, Sekhar
2010-10-08 6:44 ` Vitaly Wool
2010-10-08 6:50 ` Nori, Sekhar
2010-10-08 9:56 ` Sergei Shtylyov [this message]
2010-10-08 10:51 ` Vitaly Wool
-- strict thread matches above, loose matches on Subject: below --
2010-11-11 7:57 Savinay Dharmappa
2010-11-11 18:15 ` Sergei Shtylyov
2010-11-12 4:24 ` Savinay Dharmappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAEEADF.5070103@mvista.com \
--to=sshtylyov@mvista.com \
--cc=amakarov@ru.mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dgriego@mvista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nsekhar@ti.com \
--cc=savinay.dharmappa@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).