From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eu1sys200aog105.obsmtp.com ([207.126.144.119]) by canuck.infradead.org with smtps (Exim 4.72 #1 (Red Hat Linux)) id 1PBnTP-0007IS-7X for linux-mtd@lists.infradead.org; Fri, 29 Oct 2010 11:50:20 +0000 Message-ID: <4CCAB4D8.90807@st.com> Date: Fri, 29 Oct 2010 17:19:44 +0530 From: viresh kumar MIME-Version: 1.0 To: "dwmw2@infradead.org" Subject: Re: [PATCH V2 25/69] ST SPEAr: Add smi driver for serial NOR flash References: <238bd0ff57f8530c597157bc07f6c46dc362e1bc.1285933331.git.viresh.kumar@st.com> <4CBD32EB.5050409@st.com> In-Reply-To: <4CBD32EB.5050409@st.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Pratyush ANAND , Vipul Kumar SAMAR , Bhupesh SHARMA , Armando VISCONTI , Vipin KUMAR , Shiraz HASHIM , Amit VIRDI , Rajeev KUMAR , "linux-mtd@lists.infradead.org" , Deepak SIKRI List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/19/2010 11:25 AM, viresh kumar wrote: > On 10/01/2010 05:25 PM, Viresh KUMAR wrote: >> From: Shiraz Hashim >> >> SPEAr platforms(spear3xx/spear6xx/spear13xx) provide SMI(Serial Memory >> Interface) controller to access serial NOR flash. SMI provides a simple >> interface for SPI/serial NOR flashes and has certain inbuilt commands >> and features to support these flashes easily. It also makes it possible >> to map an address range in order to directly access (read/write) the SNOR >> over address bus. This patch intends to provide serial nor driver support >> for spear platforms which are accessed through SMI. >> >> Signed-off-by: Shiraz Hashim >> Signed-off-by: Viresh Kumar >> --- >> arch/arm/plat-spear/include/plat/smi.h | 68 ++ >> drivers/mtd/devices/Kconfig | 7 + >> drivers/mtd/devices/Makefile | 1 + >> drivers/mtd/devices/spear_smi.c | 1122 ++++++++++++++++++++++++++++++++ >> 4 files changed, 1198 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm/plat-spear/include/plat/smi.h >> create mode 100644 drivers/mtd/devices/spear_smi.c > > David, > > Any review comments on this patch?? > David, Any review comments?? -- viresh