From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eu2sys200bog112.obsmtp.com ([207.126.150.240]) by canuck.infradead.org with smtps (Exim 4.72 #1 (Red Hat Linux)) id 1Psocf-00013f-JC for linux-mtd@lists.infradead.org; Fri, 25 Feb 2011 03:45:42 +0000 Message-ID: <4D6725AA.3070204@st.com> Date: Fri, 25 Feb 2011 09:14:42 +0530 From: viresh kumar MIME-Version: 1.0 To: Linus Walleij Subject: Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Vipin KUMAR , "linux-mtd@lists.infradead.org" , "dwmw2@infradead.org" , "Artem.Bityutskiy@nokia.com" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 02/24/2011 06:08 PM, Linus Walleij wrote: > 2011/2/23 Viresh Kumar : > >> > In most of the cases partitions info, width, etc comes from board files. And >> > device structure may be defined in machine files, common to all board files. >> > Thus, we need to set platform data from board file, for which >> > fsmc_nand_set_plat_data routine is required. > Hm you create a new function, but where is it used? If it's used by a later > patch perhaps you should make a patch series instead? Linus, Actually it will be used in SPEAr patches, which will be sent separately. I could have kept it as part of that series also, but just thought to send it separately. You want me to keep it in spear patch series instead? -- viresh