From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eu1sys200aog110.obsmtp.com ([207.126.144.129]) by canuck.infradead.org with smtps (Exim 4.72 #1 (Red Hat Linux)) id 1PsvaE-00034x-TE for linux-mtd@lists.infradead.org; Fri, 25 Feb 2011 11:11:39 +0000 Message-ID: <4D678E56.8050908@st.com> Date: Fri, 25 Feb 2011 16:41:18 +0530 From: viresh kumar MIME-Version: 1.0 To: "Artem.Bityutskiy@nokia.com" Subject: Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h References: <4D6725AA.3070204@st.com> <1298632021.2798.62.camel@localhost> In-Reply-To: <1298632021.2798.62.camel@localhost> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Vipin KUMAR , "dwmw2@infradead.org" , Linus Walleij , "linux-mtd@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 02/25/2011 04:37 PM, Artem Bityutskiy wrote: > On Fri, 2011-02-25 at 09:14 +0530, viresh kumar wrote: >> > On 02/24/2011 06:08 PM, Linus Walleij wrote: >>> > > 2011/2/23 Viresh Kumar : >>> > > >>>>> > >> > In most of the cases partitions info, width, etc comes from board files. And >>>>> > >> > device structure may be defined in machine files, common to all board files. >>>>> > >> > Thus, we need to set platform data from board file, for which >>>>> > >> > fsmc_nand_set_plat_data routine is required. >>> > > Hm you create a new function, but where is it used? If it's used by a later >>> > > patch perhaps you should make a patch series instead? >> > >> > Linus, >> > >> > Actually it will be used in SPEAr patches, which will be sent separately. I could >> > have kept it as part of that series also, but just thought to send it separately. >> > You want me to keep it in spear patch series instead? > I think this is important piece of information which should be in the > patch commit message. Ok. I will resend it. -- viresh