From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eu1sys200aog108.obsmtp.com ([207.126.144.125]) by canuck.infradead.org with smtps (Exim 4.72 #1 (Red Hat Linux)) id 1Psw4s-0003IC-0I for linux-mtd@lists.infradead.org; Fri, 25 Feb 2011 11:43:18 +0000 Message-ID: <4D6795C7.6090708@st.com> Date: Fri, 25 Feb 2011 17:13:03 +0530 From: viresh kumar MIME-Version: 1.0 To: "dedekind1@gmail.com" Subject: Re: [PATCH] fsmc-nand: Add fsmc_nand_set_plat_data in linux/mtd/fsmc.h References: <1298632262.2798.66.camel@localhost> <4D6790FD.9060807@st.com> <1298633138.2798.72.camel@localhost> In-Reply-To: <1298633138.2798.72.camel@localhost> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Vipin KUMAR , "linux-mtd@lists.infradead.org" , "dwmw2@infradead.org" , Linus WALLEIJ List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 02/25/2011 04:55 PM, Artem Bityutskiy wrote: > On Fri, 2011-02-25 at 16:52 +0530, viresh kumar wrote: >> > Actually this routine will not be called many times. > Which means it is not on the hot path which means inline is not really > needed. Also, today it is not called too many times, tomorrow it could > be called more often... > >> > Only for setting >> > plat_data of few devices (depending on board). So i thought keeping >> > it inline would be better. But will change if you want. Should i move >> > it in fsmc-nand.c?? > Hi, up to you, I would not keep it in a header file, this is more about > personal taste, I guess. Ok. I have moved this to fsmc-nand.c. Will send V2. -- viresh