Re: [PATCH V2 resend] fsmc-nand: Add fsmc_nand_set_plat_data in drivers/mtd/nand/fsmc_nand.c

[viresh kumar <viresh.kumar@st.com>]

On 03/01/2011 11:21 AM, Artem Bityutskiy wrote:
> On Tue, 2011-03-01 at 09:22 +0530, viresh kumar wrote:
>> > This is what i explained in the commit message also. We don't declare device
>> > structures in board files, as this information is machine dependent, so this is present
>> > in common machine file to all boards.
>> > Now we have to set platform data. This can be be done in board_init() routine in
>> > the board specific file.
>> >  But then this routine will contain below mentioned code,
>> > and so will not look clean enough.
> Not sure why it will be not clean enough. Just add it to your board
> files, this is few lines of code after all.
> 
> if (partitions) {
> 	plat_data->partitions = partitions;
> 	plat_data->nr_partitions = nr_partitions;
> }
> plat_data->options = options;
> plat_data->width = width;
> 
> How many board files you have?
> 
>> >  so we thought of creating this function which can
>> > simply be reused by all board files.
> OK, but I think you should try to find some other place instead of
> putting it to the driver. What is the fundamental reason to put this
> code to the driver? Why it belongs to the driver?

This patch was on setting fsmc_nand_platform_data from board file.
So i thought this might be the best place for doing so. As this can be
reused by others too.

Probably this patch can be dropped now, as i have changed the approach a bit.
device structure will be in machine.c file. plat data will be defined in boards
file and i will introduce following routine, which can be used by board files.
I have already sent this patch to linux-arm-kernel list.


---------------

[RFC] device.h: add device_set_platdata routine

device.h supports device_get_platdata but doesn't support device_set_platdata.
This routine is required by platforms in which device structure is declared
in a machine specific file and platform data comes from board specific file.

This will be used by SPEAr patches sent in separate patch series.

Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
 include/linux/device.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/linux/device.h b/include/linux/device.h
index 1bf5cf0..6ce0f20 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -576,6 +576,11 @@ static inline void *dev_get_platdata(const struct device *dev)
 	return dev->platform_data;
 }
 
+static inline void dev_set_platdata(struct device *dev, void *platdata)
+{
+	dev->platform_data = platdata;
+}
+
 /*
  * Manual binding of a device to driver. See drivers/base/bus.c
  * for information on use.

-- 
viresh