Re: [PATCH 050/104] physmap_of: separate parse_obsolete_partitions to separate parser

Artem Bityutskiy
2011-06-06T08:06:29Z

On Thu, 2011-06-02 at 18:51 +0400, Dmitry Eremin-Solenikov wrote:
> Separate parse_obsolete_partitions() to external ofoldpart partitions parser.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> drivers/mtd/Kconfig | 10 +++++
> drivers/mtd/Makefile | 1 +
> drivers/mtd/maps/physmap_of.c | 53 +------------------------
> drivers/mtd/ofoldpart.c | 89 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 101 insertions(+), 52 deletions(-)
> create mode 100644 drivers/mtd/ofoldpart.c
>
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index 4be8373..2aa8afb 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -144,6 +144,16 @@ config MTD_OF_PARTS
> the partition map from the children of the flash node,
> as described in Documentation/powerpc/booting-without-of.txt.
>
> +config MTD_OF_OLD_PARTS
> + bool "Obsolete OF tree partition info"
> + depends on OF
> + help
> + This provides a partition parsing function which derives
> + the partition map from the the flash node, being an obsolete
> + way to describe physmap_of partitioning info.
> +
> + If you aren't sure you need this, you can say N.

I think this tiny piece of code does not deserve to be a separate
module...

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)