Re: [PATCH 050/104] physmap_of: separate parse_obsolete_partitions to separate parser

Artem Bityutskiy
2011-06-06T08:15:42Z

On Mon, 2011-06-06 at 12:09 +0400, Dmitry Eremin-Solenikov wrote:
> I'd really like to strip it out of physmap_of to simplify things.
>
> It parses the mtd partitions, it's a separate functional part. I can
> argue if it should be a module or just in-kernel part, if it should
> be
> visible to users (or just autoselected by physmap_of), but I'd
> definitely prefer to have this as a separate source file hooking into
> generic mtd_parse subsystem.

I understand your desire to keep physmap_of nice and shiny and have all
the crap separate, but that is really too small amount of code to even a
separate file. And after all, that's physmap_of's crap, you can keep it
in separate functions and register as a separate parser, but put it say,
to the end of phusmap_of file with a big fat comment telling that no one
should use it, you can add a deprication date, a warning, etc as well.

P.S. I'm not very aware of OF so if adding a warning is a stupid
suggestion, please just ignore it.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)