From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Brian Walsh <brian@walsh.ws>,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>,
Deepak Sanexa <dsanexa@mvista.com>,
dedekind1@gmail.com
Subject: Re: Question reg. parsing of mtd partitions
Date: Thu, 09 Jun 2011 13:08:09 +0400 [thread overview]
Message-ID: <4DF08D79.9090707@gmail.com> (raw)
In-Reply-To: <20110609083419.GA23553@doriath.ww600.siemens.net>
On 09.06.2011 12:34, Dmitry Eremin-Solenikov wrote:
> Hello, colleagues,
>
> While doing MTD partitions cleanup I noticed one strange thing.
> parse_mtd_partitions function bears one extra argument (origin)
> which isn't clearly described, set to non-zero only by ixp4xx.c
> driver and then read by redboot partition table handling. I wander if we
> can add some other way to handle this situation and drop this extra 0
> argument from lots of drivers/handlers/etc.
>
> Could you please check it?
At least the ixp4xx part was added by commit f40a6f1cc7fe522,
back in 2006:
If the amount of flash is not divisible by 2 then the mask in
parse_mtd_partitions would fail to work as designed. Passing in the
base address corrects this problem.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2011-06-09 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 8:34 Question reg. parsing of mtd partitions Dmitry Eremin-Solenikov
2011-06-09 9:08 ` Dmitry Eremin-Solenikov [this message]
2011-06-09 9:23 ` Dmitry Eremin-Solenikov
2011-06-10 12:49 ` Brian Walsh
2011-06-10 13:09 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF08D79.9090707@gmail.com \
--to=dbaryshkov@gmail.com \
--cc=brian@walsh.ws \
--cc=dedekind1@gmail.com \
--cc=dsanexa@mvista.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).