From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wy0-f177.google.com ([74.125.82.177]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QUgMF-0008L2-06 for linux-mtd@lists.infradead.org; Thu, 09 Jun 2011 14:37:16 +0000 Received: by wyb28 with SMTP id 28so1570376wyb.36 for ; Thu, 09 Jun 2011 07:37:12 -0700 (PDT) Message-ID: <4DF0DA9A.2050301@gmail.com> Date: Thu, 09 Jun 2011 18:37:14 +0400 From: Dmitry Eremin-Solenikov MIME-Version: 1.0 To: dedekind1@gmail.com Subject: Re: [PATCH 01/17] mtd: prepare to convert of_mtd_parse_partitions to partition parser References: <1307629388-24769-1-git-send-email-dbaryshkov@gmail.com> <1307629388-24769-2-git-send-email-dbaryshkov@gmail.com> <1307629589.7374.103.camel@localhost> In-Reply-To: <1307629589.7374.103.camel@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Woodhouse , linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09.06.2011 18:26, Artem Bityutskiy wrote: > On Thu, 2011-06-09 at 18:22 +0400, Dmitry Eremin-Solenikov wrote: >> Prepare to convert of_mtd_parse_partitions() to usual partitions parser: >> 1) Register ofpart parser >> 2) Internally don't use passed device for error printing >> 3) Add device_node to mtd_info struct >> 4) Move of_mtd_parse_partitions from __devinit to common text section >> 5) add ofpart to the default list of partition parsers >> >> Signed-off-by: Dmitry Eremin-Solenikov >> --- >> drivers/mtd/mtdcore.c | 19 +++++++++++++++++++ >> drivers/mtd/mtdpart.c | 8 ++++++-- >> drivers/mtd/ofpart.c | 30 ++++++++++++++++++++++++++++-- >> include/linux/mtd/mtd.h | 5 +++++ >> include/linux/mtd/partitions.h | 2 +- >> 5 files changed, 59 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c >> index 1326747..2d5b865 100644 >> --- a/drivers/mtd/mtdcore.c >> +++ b/drivers/mtd/mtdcore.c >> @@ -36,6 +36,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -446,6 +447,10 @@ int mtd_device_register(struct mtd_info *master, >> const struct mtd_partition *parts, >> int nr_parts) >> { >> +#ifdef CONFIG_OF >> + if (master->node) >> + of_node_get(master->node); >> +#endif > > These ifdefs are not very nice, do you have ideas how to avoid them? > Ideally, mtdcore should not know or bother about OF things. All > OF-specific things should be done in ofpart.c... I know they aren't nice. OTOH ofpart.c also seems a bit non-logical: one can have of node in the MTD, but doesn't (strangely) want to compile in ofpart.c. Of course I can add separate small of-handling functions (to do OF handling) to mtdcore.c to be replaced by empty functions in the absence of CONFIG_OF, but this also look like overhead for me. -- With best wishes Dmitry