From: Igor Grinberg <grinberg@compulab.co.il>
To: Lei Wen <leiwen@marvell.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <zonque@gmail.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MTD: pxa3xx_nand: enable multiple chip select support
Date: Mon, 27 Jun 2011 16:22:05 +0300 [thread overview]
Message-ID: <4E0883FD.3080707@compulab.co.il> (raw)
In-Reply-To: <1309000666-5242-1-git-send-email-leiwen@marvell.com>
On 06/25/11 14:17, Lei Wen wrote:
> Current pxa3xx_nand controller has two chip select which
> both be workable. This patch enable this feature.
>
> Update platform driver to support this feature.
>
> Another notice should be taken that:
> When you want to use this feature, you should not enable the
> keep configuration feature, for two chip select could be
> attached with different nand chip. The different page size
> and timing requirement make the keep configuration impossible.
>
> Signed-off-by: Lei Wen <leiwen@marvell.com>
> ---
> arch/arm/mach-mmp/aspenite.c | 5 +-
> arch/arm/mach-pxa/cm-x300.c | 5 +-
> arch/arm/mach-pxa/colibri-pxa3xx.c | 5 +-
> arch/arm/mach-pxa/littleton.c | 5 +-
> arch/arm/mach-pxa/mxm8x10.c | 9 +-
> arch/arm/mach-pxa/raumfeld.c | 5 +-
> arch/arm/mach-pxa/zylonite.c | 5 +-
> arch/arm/plat-pxa/include/plat/pxa3xx_nand.h | 19 +-
> drivers/mtd/nand/pxa3xx_nand.c | 512 +++++++++++++++-----------
> 9 files changed, 346 insertions(+), 224 deletions(-)
~100 lines less - nice!
[...]
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index b7db1b2..0825b7d 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
[...]
> @@ -616,7 +627,7 @@ static int prepare_command_pool(struct pxa3xx_nand_info *info, int command,
>
> default:
> exec_cmd = 0;
> - printk(KERN_ERR "pxa3xx-nand: non-supported"
> + dev_err(&info->pdev->dev, "pxa3xx-nand: non-supported"
If you use dev_err(), why do you still need pxa3xx-nand in the message?
--
Regards,
Igor.
next prev parent reply other threads:[~2011-06-27 13:22 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 3:17 [PATCH] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-06-22 11:39 ` Daniel Mack
2011-06-22 12:21 ` Lei Wen
2011-06-22 13:06 ` Daniel Mack
2011-06-23 6:22 ` Lei Wen
2011-06-22 13:45 ` Igor Grinberg
2011-06-23 6:35 ` Lei Wen
2011-06-23 10:44 ` Igor Grinberg
2011-06-25 11:17 ` Lei Wen
2011-06-25 12:32 ` Daniel Mack
2011-06-25 12:51 ` Lei Wen
2011-06-27 13:22 ` Igor Grinberg [this message]
2011-06-28 7:32 ` Artem Bityutskiy
2011-06-28 15:12 ` Lei Wen
2011-06-29 3:51 ` [PATCH V3 0/9] pxa3xx_nand: add two " Lei Wen
2011-06-29 9:00 ` Igor Grinberg
2011-06-29 10:20 ` Artem Bityutskiy
2011-07-04 9:27 ` Lei Wen
2011-07-04 9:25 ` [PATCH V4 0/4] " Lei Wen
2011-07-08 3:34 ` [PATCH V5 0/3] " Lei Wen
2011-07-12 10:28 ` [PATCH V6 0/4] " Lei Wen
2011-07-12 14:35 ` [PATCH V7 " Lei Wen
2011-07-15 3:44 ` [PATCH V8 " Lei Wen
2011-07-20 4:51 ` Artem Bityutskiy
2011-07-15 3:44 ` [PATCH V8 1/4] MTD: pxa3xx_nand: enhance suspend and resume routine Lei Wen
2011-07-15 3:44 ` [PATCH V8 2/4] MTD: pxa3xx_nand: convert all printk into dev_* Lei Wen
2011-07-15 3:44 ` [PATCH V8 3/4] MTD: pxa3xx_nand: sperate each chip individual info Lei Wen
2011-07-15 3:44 ` [PATCH V8 4/4] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-07-12 14:35 ` [PATCH V7 1/4] MTD: pxa3xx_nand: enhance suspend and resume routine Lei Wen
2011-07-13 10:53 ` Sergei Shtylyov
2011-07-12 14:35 ` [PATCH V7 2/4] MTD: pxa3xx_nand: convert all printk into dev_* Lei Wen
2011-07-13 10:57 ` Sergei Shtylyov
2011-07-13 12:41 ` Lei Wen
2011-07-13 14:35 ` Sergei Shtylyov
2011-07-12 14:35 ` [PATCH V7 3/4] MTD: pxa3xx_nand: sperate each chip individual info Lei Wen
2011-07-12 14:35 ` [PATCH V7 4/4] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-07-12 10:28 ` [PATCH V6 1/4] MTD: pxa3xx_nand: convert all printk into dev_* Lei Wen
2011-07-12 10:28 ` [PATCH V6 2/4] MTD: pxa3xx_nand: sperate each chip individual info Lei Wen
2011-07-12 10:28 ` [PATCH V6 3/4] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-07-12 10:28 ` [PATCH V6 4/4] MTD: pxa3xx_nand: enhance suspend and resume routine Lei Wen
2011-07-12 11:39 ` Daniel Mack
2011-07-12 12:02 ` Daniel Mack
2011-07-12 15:56 ` Igor Grinberg
2011-07-12 17:35 ` Daniel Mack
2011-07-08 3:34 ` [PATCH 1/3] MTD: pxa3xx_nand: convert all printk into dev_* Lei Wen
2011-07-08 3:34 ` [PATCH 2/3] MTD: pxa3xx_nand: sperate each chip individual info Lei Wen
2011-07-08 3:34 ` [PATCH 3/3] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-07-04 9:25 ` [PATCH 1/4] MTD: pxa3xx_nand: convert all printk into dev_* Lei Wen
2011-07-04 9:25 ` [PATCH 2/4] MTD: pxa3xx_nand: sperate each chip individual info Lei Wen
2011-07-06 7:29 ` Igor Grinberg
2011-07-04 9:25 ` [PATCH 3/4] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-07-06 6:53 ` Artem Bityutskiy
2011-07-06 6:54 ` Lei Wen
2011-07-06 7:07 ` Artem Bityutskiy
2011-07-06 7:41 ` Igor Grinberg
2011-07-07 6:26 ` Lei Wen
2011-07-07 8:59 ` Igor Grinberg
2011-07-07 9:06 ` Lei Wen
2011-07-07 11:23 ` Igor Grinberg
2011-07-11 14:49 ` Daniel Mack
2011-07-11 18:19 ` Igor Grinberg
2011-07-11 18:53 ` Daniel Mack
2011-07-11 19:25 ` Igor Grinberg
2011-07-12 9:40 ` Lei Wen
2011-07-12 9:57 ` Daniel Mack
2011-07-12 10:29 ` Lei Wen
2011-07-12 12:05 ` Daniel Mack
2011-07-12 12:48 ` Daniel Mack
2011-07-12 15:49 ` Igor Grinberg
2011-07-04 9:25 ` [PATCH 4/4] ARM: mmp/pxa: fix nand platform data Lei Wen
2011-06-29 3:51 ` [PATCH 1/9] MTD: pxa3xx_nand: convert all printk into dev_* Lei Wen
2011-06-29 3:51 ` [PATCH 2/9] MTD: pxa3xx_nand: enable multiple chip select support Lei Wen
2011-06-29 7:11 ` Artem Bityutskiy
2011-06-29 7:16 ` Lei Wen
2011-06-29 3:51 ` [PATCH 3/9] ARM: aspenite: fix nand platform data Lei Wen
2011-06-29 3:51 ` [PATCH 4/9] ARM: cm-x300: " Lei Wen
2011-06-29 3:51 ` [PATCH 5/9] ARM: colibri-pxa3xx: " Lei Wen
2011-06-29 3:51 ` [PATCH 6/9] ARM: littleton: " Lei Wen
2011-06-29 3:51 ` [PATCH 7/9] ARM: mxm8x10: " Lei Wen
2011-06-29 3:51 ` [PATCH 8/9] ARM: raumfeld: " Lei Wen
2011-06-29 3:51 ` [PATCH 9/9] ARM: zylonite: " Lei Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0883FD.3080707@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=leiwen@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).