Re: [PATCH v6 2/4] ARM: mxs: add new a pad control

[Huang Shijie <b32955@freescale.com>]

于 2011年07月08日 15:23, Uwe Kleine-König 写道:
> On Fri, Jul 08, 2011 at 01:28:03PM +0800, Huang Shijie wrote:
>> add a new pad control which is used in some rare cases,
>> such as gpmi-nand device.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>> ---
>>   arch/arm/mach-mxs/include/mach/iomux.h |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mxs/include/mach/iomux.h b/arch/arm/mach-mxs/include/mach/iomux.h
>> index 7abdf58..1f31762 100644
>> --- a/arch/arm/mach-mxs/include/mach/iomux.h
>> +++ b/arch/arm/mach-mxs/include/mach/iomux.h
>> @@ -94,6 +94,9 @@ typedef u32 iomux_cfg_t;
>>   /* generic pad control used in most cases */
>>   #define MXS_PAD_CTRL	(MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL)
>>
>> +/* special pad control used in rare cases */
> I'd not talk about "rare cases" in the comment. It applies to most pads,
> that they are used rarely (at most once per machine :-)
ok. I will remove this comment in next version. :)

>> +#define MXS_PAD_CTRL_12MA	(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL)
> But other than that I fully support this definition.
thanks.

Best Regards
Huang Shijie
> Best regards
> Uwe
>