From: Orjan Friberg <of@flatfrog.com>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: JFFS2 oops when writing to two partitions simultaneously
Date: Thu, 26 Jan 2012 15:07:07 +0100 [thread overview]
Message-ID: <4F215E0B.107@flatfrog.com> (raw)
In-Reply-To: <OFF7DA2700.9D726421-ONC1257991.004865DC-C1257991.0048F71D@transmode.se>
On 01/26/2012 02:16 PM, Joakim Tjernlund wrote:
> Anyhow, I think it is stupid (and probably buggy) to have kfree and kmalloc
> as separate. Why is it not done at the same time?
To me it looks like the lock must be held the entire time. We can't
allow two contexts using (i.e. freeing/allocating/writing to) the
compressor's compr_buf.
Maybe the lock used here should be on a per-compressor basis, rather
than on the list as a whole. (The list lock is still needed when adding
to/removing from the list of course.)
--
Orjan Friberg
FlatFrog Laboratories AB
next prev parent reply other threads:[~2012-01-26 14:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 9:55 JFFS2 oops when writing to two partitions simultaneously Orjan Friberg
2012-01-24 17:15 ` Orjan Friberg
2012-01-24 19:02 ` Orjan Friberg
2012-01-25 19:53 ` Orjan Friberg
2012-01-25 21:01 ` Orjan Friberg
2012-01-26 8:19 ` Joakim Tjernlund
2012-01-26 9:02 ` Orjan Friberg
2012-01-26 9:53 ` Joakim Tjernlund
2012-01-26 9:02 ` Orjan Friberg
2012-01-26 11:53 ` Joakim Tjernlund
2012-01-26 12:51 ` Orjan Friberg
2012-01-26 13:16 ` Joakim Tjernlund
2012-01-26 14:07 ` Orjan Friberg [this message]
2012-01-26 14:23 ` Joakim Tjernlund
2012-01-26 14:53 ` Orjan Friberg
2012-01-26 15:17 ` Joakim Tjernlund
2012-01-26 15:25 ` Orjan Friberg
2012-01-26 16:05 ` Orjan Friberg
2012-01-26 16:17 ` Joakim Tjernlund
2012-01-26 14:52 ` Joakim Tjernlund
2012-01-26 15:09 ` Joakim Tjernlund
2012-01-26 15:18 ` Orjan Friberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F215E0B.107@flatfrog.com \
--to=of@flatfrog.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox