From: Orjan Friberg <of@flatfrog.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Richard Purdie <rpurdie@openedhand.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: Re: CONFIG_PREEMPT and JFFS2 oops
Date: Thu, 26 Jan 2012 18:54:49 +0100 [thread overview]
Message-ID: <4F219369.3040208@flatfrog.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201260953550.32667@utopia.booyaka.com>
On 01/26/2012 05:57 PM, Paul Walmsley wrote:
>>
>> You just throw away best_buf here, don't you?
>
> You're right. It's even worse than that. best_buf will contain the data
> from the last compressor used. And it will be prematurely freed. Here's
> a fixed version.
I've tested this version for a while now with the same result as before.
No oopses, no spinlock violations. I copied a 2MB file from the SD/MMC
partition to the two JFFS2 partitions and md5summ'ed it a bunch of
times. After that I unmounted and remounted both partitions.
I do see a steady memory usage increase when doing continuous testing,
but whether that's normal I don't know. I see at least some of it being
reclaimed when unmounting the JFFS2 partitions (grep jffs2 /proc/slabinfo).
--
Orjan Friberg
FlatFrog Laboratories AB
next prev parent reply other threads:[~2012-01-26 17:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F206213.9070704@flatfrog.com>
[not found] ` <alpine.DEB.2.00.1201251351500.5324@utopia.booyaka.com>
2012-01-26 10:15 ` CONFIG_PREEMPT and JFFS2 oops Orjan Friberg
2012-01-26 11:19 ` Joakim Tjernlund
2012-01-26 11:54 ` Orjan Friberg
2012-01-26 16:09 ` Paul Walmsley
2012-01-26 16:28 ` Joakim Tjernlund
2012-01-26 16:35 ` Paul Walmsley
2012-01-26 16:38 ` Paul Walmsley
2012-01-26 16:48 ` Joakim Tjernlund
2012-01-26 16:57 ` Paul Walmsley
2012-01-26 17:33 ` Joakim Tjernlund
2012-01-26 20:01 ` Joakim Tjernlund
2012-01-28 9:51 ` Paul Walmsley
2012-01-28 14:42 ` Joakim Tjernlund
2012-01-28 9:50 ` Paul Walmsley
2012-01-26 17:54 ` Orjan Friberg [this message]
2012-01-26 16:37 ` Orjan Friberg
2012-01-26 16:43 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F219369.3040208@flatfrog.com \
--to=of@flatfrog.com \
--cc=dwmw2@infradead.org \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rpurdie@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox