* Re: linux-next: Tree for Feb 2 (fs/jffs2)
[not found] <20120202144516.11b33e667a7cbb8d85d96226@canb.auug.org.au>
@ 2012-02-02 18:24 ` Randy Dunlap
2012-02-02 23:44 ` Stephen Rothwell
2012-02-03 5:37 ` Artem Bityutskiy
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2012-02-02 18:24 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-mtd, linux-next, David Woodhouse, LKML
On 02/01/2012 07:45 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20120201:
fs/jffs2/*.c still contains uses of ->read etc. instead of using
mtd_read() etc.
fs/jffs2/read.c:36:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/read.c:112:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/nodemgmt.c:669:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/readinode.c:83:9: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/readinode.c:676:9: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/readinode.c:954:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/readinode.c:1040:9: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/readinode.c:1216:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/readinode.c:1275:10: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/scan.c:286:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/gc.c:590:8: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/gc.c:894:10: error: 'struct mtd_info' has no member named 'read'
fs/jffs2/gc.c:977:9: error: 'struct mtd_info' has no member named 'read'
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Feb 2 (fs/jffs2)
2012-02-02 18:24 ` linux-next: Tree for Feb 2 (fs/jffs2) Randy Dunlap
@ 2012-02-02 23:44 ` Stephen Rothwell
2012-02-03 0:41 ` Brian Norris
2012-02-03 5:37 ` Artem Bityutskiy
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2012-02-02 23:44 UTC (permalink / raw)
To: Artem Bityutskiy
Cc: linux-mtd, Randy Dunlap, linux-next, David Woodhouse, LKML
[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]
On Thu, 02 Feb 2012 10:24:30 -0800 Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> fs/jffs2/*.c still contains uses of ->read etc. instead of using
> mtd_read() etc.
>
> fs/jffs2/read.c:36:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/read.c:112:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/nodemgmt.c:669:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/readinode.c:83:9: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/readinode.c:676:9: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/readinode.c:954:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/readinode.c:1040:9: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/readinode.c:1216:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/readinode.c:1275:10: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/scan.c:286:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/gc.c:590:8: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/gc.c:894:10: error: 'struct mtd_info' has no member named 'read'
> fs/jffs2/gc.c:977:9: error: 'struct mtd_info' has no member named 'read'
They were probably missed because they use the jffs2_flash_read() macro
in fs/jffs2/os-linux.h
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Feb 2 (fs/jffs2)
2012-02-02 23:44 ` Stephen Rothwell
@ 2012-02-03 0:41 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2012-02-03 0:41 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Artem Bityutskiy, LKML, Randy Dunlap, linux-next, linux-mtd,
David Woodhouse
On Thu, Feb 2, 2012 at 3:44 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Thu, 02 Feb 2012 10:24:30 -0800 Randy Dunlap <rdunlap@xenotime.net> wrote:
>>
>> fs/jffs2/*.c still contains uses of ->read etc. instead of using
>> mtd_read() etc.
>>
>> fs/jffs2/read.c:36:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/read.c:112:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/nodemgmt.c:669:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/readinode.c:83:9: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/readinode.c:676:9: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/readinode.c:954:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/readinode.c:1040:9: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/readinode.c:1216:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/readinode.c:1275:10: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/scan.c:286:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/gc.c:590:8: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/gc.c:894:10: error: 'struct mtd_info' has no member named 'read'
>> fs/jffs2/gc.c:977:9: error: 'struct mtd_info' has no member named 'read'
>
> They were probably missed because they use the jffs2_flash_read() macro
> in fs/jffs2/os-linux.h
I just sent a patch that fixes this, FYI. If Artem and Randy ACK it,
it'll probably go into l2-mtd-2.6.git.
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Feb 2 (fs/jffs2)
2012-02-02 18:24 ` linux-next: Tree for Feb 2 (fs/jffs2) Randy Dunlap
2012-02-02 23:44 ` Stephen Rothwell
@ 2012-02-03 5:37 ` Artem Bityutskiy
1 sibling, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2012-02-03 5:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, David Woodhouse, LKML, linux-mtd
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
On Thu, 2012-02-02 at 10:24 -0800, Randy Dunlap wrote:
> On 02/01/2012 07:45 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20120201:
>
>
> fs/jffs2/*.c still contains uses of ->read etc. instead of using
> mtd_read() etc.
The fix from Brian has been pushed to l2-mtd.git, should be fixed.
Thanks for reporting and sorry for the breakage.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-03 5:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120202144516.11b33e667a7cbb8d85d96226@canb.auug.org.au>
2012-02-02 18:24 ` linux-next: Tree for Feb 2 (fs/jffs2) Randy Dunlap
2012-02-02 23:44 ` Stephen Rothwell
2012-02-03 0:41 ` Brian Norris
2012-02-03 5:37 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox