Re: [PATCH] mtd: fix the wrong check condition

Brian Norris
2012-02-18T05:43:44Z

On Fri, Feb 17, 2012 at 12:50 AM, Florian Fainelli <ffainelli@freebox.fr> wrote:
> Le 02/17/12 04:07, Huang Shijie a écrit :
>> Sorry. I did not check the log carefully.
>>
>> the Hynix nand does _not_ pass the CRC check, but it passed the "ONFI"
>> string check.
>
> This is exactly what I saw too with a different Hynix chip, it replied ONFI,
> but the CRC check failed.

So your root detection issue is actually that this Hynix chip is
neither ONFI-compliant nor does it have a good ID decoding scheme,
hence the need for the ID table patch (separate; I'll review it soon).

>>
>> The log "ONFI flash detected" made me misunderstood.
>
> Yes I agree, the log is there too soon, thanks for your patch.

I agree as well. I'll ACK the other patch.

Thanks,
Brian