* [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
@ 2012-02-23 16:59 John Crispin
2012-03-09 8:40 ` Artem Bityutskiy
2012-03-09 11:27 ` Artem Bityutskiy
0 siblings, 2 replies; 9+ messages in thread
From: John Crispin @ 2012-02-23 16:59 UTC (permalink / raw)
To: David Woodhouse; +Cc: Daniel Schwierzeck, linux-mtd, John Crispin
From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
command line parsing of MTD partitions does not work anymore.
Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
Signed-off-by: John Crispin <blogic@openwrt.org>
---
drivers/mtd/maps/lantiq-flash.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/maps/lantiq-flash.c b/drivers/mtd/maps/lantiq-flash.c
index 395ebfe..ccc6954 100644
--- a/drivers/mtd/maps/lantiq-flash.c
+++ b/drivers/mtd/maps/lantiq-flash.c
@@ -45,6 +45,7 @@ struct ltq_mtd {
};
static char ltq_map_name[] = "ltq_nor";
+static const char *ltq_probe_types[] __devinitconst = { "cmdlinepart", NULL };
static map_word
ltq_read16(struct map_info *map, unsigned long adr)
@@ -168,7 +169,7 @@ ltq_mtd_probe(struct platform_device *pdev)
cfi->addr_unlock1 ^= 1;
cfi->addr_unlock2 ^= 1;
- err = mtd_device_parse_register(ltq_mtd->mtd, NULL, 0,
+ err = mtd_device_parse_register(ltq_mtd->mtd, ltq_probe_types, 0,
ltq_mtd_data->parts, ltq_mtd_data->nr_parts);
if (err) {
dev_err(&pdev->dev, "failed to add partitions\n");
--
1.7.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-02-23 16:59 [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions John Crispin
@ 2012-03-09 8:40 ` Artem Bityutskiy
2012-03-09 8:58 ` John Crispin
2012-03-09 11:27 ` Artem Bityutskiy
1 sibling, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2012-03-09 8:40 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse
[-- Attachment #1: Type: text/plain, Size: 2558 bytes --]
On Thu, 2012-02-23 at 17:59 +0100, John Crispin wrote:
> From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>
> Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
> command line parsing of MTD partitions does not work anymore.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
> Signed-off-by: John Crispin <blogic@openwrt.org>
I would like to compile-test this patch. I've got this error when
compiling with mips-linux-gcc-4.6.0 and the attached defconfig:
from include/linux/sched.h:55,
from arch/mips/kernel/asm-offsets.c:13:
include/linux/bitops.h: In function 'hweight_long':
include/linux/bitops.h:55:26: warning: signed and unsigned type in conditional expression [-Wsign-compare]
arch/mips/kernel/asm-offsets.c: At top level:
arch/mips/kernel/asm-offsets.c:21:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:76:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:88:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:105:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:136:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:175:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:211:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:257:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes]
arch/mips/kernel/asm-offsets.c:295:6: warning: no previous prototype for 'output_irq_cpustat_t_defines' [-Wmissing-prototypes]
In file included from include/linux/kernel.h:17:0,
from arch/mips/kernel/cpu-probe.c:15:
include/linux/bitops.h: In function 'hweight_long':
include/linux/bitops.h:55:26: error: signed and unsigned type in conditional expression [-Werror=sign-compare]
arch/mips/kernel/cpu-probe.c: At top level:
arch/mips/kernel/cpu-probe.c:64:6: error: no previous prototype for 'r4k_wait_irqoff' [-Werror=missing-prototypes]
arch/mips/kernel/cpu-probe.c:154:13: error: no previous prototype for 'check_wait' [-Werror=missing-prototypes]
cc1: all warnings being treated as errors
I use W=1 when compiling. Any suggestions?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: l2_lantiq_defconfig --]
[-- Type: text/plain, Size: 3055 bytes --]
CONFIG_LANTIQ=y
CONFIG_HZ_1000=y
# CONFIG_SECCOMP is not set
CONFIG_EXPERIMENTAL=y
CONFIG_SYSVIPC=y
CONFIG_LOG_BUF_SHIFT=14
CONFIG_EXPERT=y
# CONFIG_KALLSYMS is not set
# CONFIG_HOTPLUG is not set
# CONFIG_EPOLL is not set
# CONFIG_SIGNALFD is not set
# CONFIG_TIMERFD is not set
# CONFIG_EVENTFD is not set
CONFIG_SLAB=y
# CONFIG_BLK_DEV_BSG is not set
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
CONFIG_PCI=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
CONFIG_INET=y
# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
# CONFIG_INET_XFRM_MODE_TUNNEL is not set
# CONFIG_INET_XFRM_MODE_BEET is not set
# CONFIG_INET_DIAG is not set
# CONFIG_IPV6 is not set
CONFIG_MTD=y
CONFIG_MTD_REDBOOT_PARTS=y
CONFIG_MTD_REDBOOT_PARTS_UNALLOCATED=y
CONFIG_MTD_REDBOOT_PARTS_READONLY=y
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_AR7_PARTS=y
CONFIG_MTD_CHAR=y
CONFIG_MTD_BLOCK=y
CONFIG_FTL=y
CONFIG_NFTL=y
CONFIG_NFTL_RW=y
CONFIG_INFTL=y
CONFIG_RFD_FTL=y
CONFIG_SSFDC=y
CONFIG_SM_FTL=y
CONFIG_MTD_OOPS=y
CONFIG_MTD_SWAP=y
CONFIG_MTD_CFI=y
CONFIG_MTD_JEDECPROBE=y
CONFIG_MTD_CFI_ADV_OPTIONS=y
CONFIG_MTD_CFI_GEOMETRY=y
CONFIG_MTD_CFI_I8=y
CONFIG_MTD_OTP=y
CONFIG_MTD_CFI_INTELEXT=y
CONFIG_MTD_CFI_AMDSTD=y
CONFIG_MTD_CFI_STAA=y
CONFIG_MTD_ROM=y
CONFIG_MTD_ABSENT=y
CONFIG_MTD_COMPLEX_MAPPINGS=y
CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_PHYSMAP_COMPAT=y
CONFIG_MTD_LANTIQ=y
CONFIG_MTD_PCI=y
CONFIG_MTD_GPIO_ADDR=y
CONFIG_MTD_INTEL_VR_NOR=y
CONFIG_MTD_PLATRAM=y
CONFIG_MTD_LATCH_ADDR=y
CONFIG_MTD_PMC551=y
CONFIG_MTD_PMC551_BUGFIX=y
CONFIG_MTD_PMC551_DEBUG=y
CONFIG_MTD_SLRAM=y
CONFIG_MTD_PHRAM=y
CONFIG_MTD_MTDRAM=y
CONFIG_MTD_BLOCK2MTD=y
CONFIG_MTD_DOCG3=y
CONFIG_MTD_NAND_ECC_SMC=y
CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_ECC_BCH=y
CONFIG_MTD_NAND_MUSEUM_IDS=y
CONFIG_MTD_NAND_DENALI=y
CONFIG_MTD_NAND_RICOH=y
CONFIG_MTD_NAND_DISKONCHIP=y
CONFIG_MTD_NAND_DISKONCHIP_PROBE_ADVANCED=y
CONFIG_MTD_NAND_DISKONCHIP_PROBE_HIGH=y
CONFIG_MTD_NAND_DISKONCHIP_BBTWRITE=y
CONFIG_MTD_NAND_DOCG4=y
CONFIG_MTD_NAND_CAFE=y
CONFIG_MTD_NAND_NANDSIM=y
CONFIG_MTD_NAND_PLATFORM=y
CONFIG_MTD_ONENAND=y
CONFIG_MTD_ONENAND_VERIFY_WRITE=y
CONFIG_MTD_ONENAND_GENERIC=y
CONFIG_MTD_ONENAND_OTP=y
CONFIG_MTD_ONENAND_2X_PROGRAM=y
CONFIG_MTD_ONENAND_SIM=y
CONFIG_MTD_LPDDR=y
CONFIG_MTD_UBI=y
CONFIG_MTD_UBI_GLUEBI=y
CONFIG_IDE=y
CONFIG_IDE_GENERIC=y
CONFIG_BLK_DEV_GENERIC=y
CONFIG_BLK_DEV_CMD64X=y
CONFIG_NETDEVICES=y
CONFIG_PCNET32=y
# CONFIG_INPUT_MOUSEDEV is not set
# CONFIG_INPUT_KEYBOARD is not set
# CONFIG_INPUT_MOUSE is not set
CONFIG_SERIO_RAW=y
# CONFIG_VT is not set
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_CONSOLE=y
# CONFIG_SERIAL_8250_PCI is not set
# CONFIG_HW_RANDOM is not set
# CONFIG_HWMON is not set
# CONFIG_HID_SUPPORT is not set
# CONFIG_USB_SUPPORT is not set
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y
# CONFIG_EXT3_FS_XATTR is not set
# CONFIG_DNOTIFY is not set
CONFIG_PROC_KCORE=y
CONFIG_TMPFS=y
CONFIG_CONFIGFS_FS=y
CONFIG_JFFS2_FS=y
CONFIG_UBIFS_FS=y
CONFIG_UBIFS_FS_XATTR=y
CONFIG_UBIFS_FS_ADVANCED_COMPR=y
CONFIG_LOGFS=y
CONFIG_CRAMFS=y
CONFIG_SQUASHFS=y
CONFIG_MAGIC_SYSRQ=y
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-03-09 8:40 ` Artem Bityutskiy
@ 2012-03-09 8:58 ` John Crispin
2012-03-09 9:08 ` Artem Bityutskiy
2012-03-09 11:09 ` Artem Bityutskiy
0 siblings, 2 replies; 9+ messages in thread
From: John Crispin @ 2012-03-09 8:58 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse
On 09/03/12 09:40, Artem Bityutskiy wrote:
> On Thu, 2012-02-23 at 17:59 +0100, John Crispin wrote:
>> From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>>
>> Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
>> command line parsing of MTD partitions does not work anymore.
>>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>
Hi Artem,
i have tested this patch using arch/mips/configs/xway_defconfig and
gcc4.6+linaro
i will try a build with your config in a moment
which git-tree are you building on top of ?
thanks,
John
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-03-09 8:58 ` John Crispin
@ 2012-03-09 9:08 ` Artem Bityutskiy
2012-03-09 10:59 ` John Crispin
2012-03-09 11:09 ` Artem Bityutskiy
1 sibling, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2012-03-09 9:08 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse
On Fri, 2012-03-09 at 09:58 +0100, John Crispin wrote:
> On 09/03/12 09:40, Artem Bityutskiy wrote:
> > On Thu, 2012-02-23 at 17:59 +0100, John Crispin wrote:
> >> From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
> >>
> >> Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
> >> command line parsing of MTD partitions does not work anymore.
> >>
> >> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
> >> Signed-off-by: John Crispin <blogic@openwrt.org>
> >
>
> Hi Artem,
>
> i have tested this patch using arch/mips/configs/xway_defconfig and
> gcc4.6+linaro
>
> i will try a build with your config in a moment
>
> which git-tree are you building on top of ?
l2-mtd.git: http://git.infradead.org/users/dedekind/l2-mtd.git
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-03-09 9:08 ` Artem Bityutskiy
@ 2012-03-09 10:59 ` John Crispin
2012-03-09 11:16 ` Artem Bityutskiy
0 siblings, 1 reply; 9+ messages in thread
From: John Crispin @ 2012-03-09 10:59 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse, Ralf Baechle
On 09/03/12 09:40, Artem Bityutskiy wrote:
> I would like to compile-test this patch. I've got this error when
> compiling with mips-linux-gcc-4.6.0 and the attached defconfig:
>
> from include/linux/sched.h:55,
> from arch/mips/kernel/asm-offsets.c:13:
> include/linux/bitops.h: In function 'hweight_long':
> include/linux/bitops.h:55:26: warning: signed and unsigned type in conditional expression [-Wsign-compare]
> arch/mips/kernel/asm-offsets.c: At top level:
> arch/mips/kernel/asm-offsets.c:21:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:76:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:88:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:105:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:136:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:175:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:211:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:257:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes]
> arch/mips/kernel/asm-offsets.c:295:6: warning: no previous prototype for 'output_irq_cpustat_t_defines' [-Wmissing-prototypes]
> In file included from include/linux/kernel.h:17:0,
> from arch/mips/kernel/cpu-probe.c:15:
> include/linux/bitops.h: In function 'hweight_long':
> include/linux/bitops.h:55:26: error: signed and unsigned type in conditional expression [-Werror=sign-compare]
> arch/mips/kernel/cpu-probe.c: At top level:
> arch/mips/kernel/cpu-probe.c:64:6: error: no previous prototype for 'r4k_wait_irqoff' [-Werror=missing-prototypes]
> arch/mips/kernel/cpu-probe.c:154:13: error: no previous prototype for 'check_wait' [-Werror=missing-prototypes]
> cc1: all warnings being treated as errors
>
> I use W=1 when compiling. Any suggestions?
Hi,
just tried 4.5 where the same happens. The errors don't seem to have
been introduced by 4.6.
apart from that the -Werror is set by arch/mips/ as follows
bcm63xx/boards/Makefile:ccflags-y := -Werror
fw/arc/Makefile:ccflags-y := -Werror
jz4740/Makefile:ccflags-y := -Werror -Wall
Kbuild:subdir-ccflags-y := -Werror
oprofile/Makefile:ccflags-y := -Werror
pmc-sierra/yosemite/Makefile:ccflags-y := -Werror
powertv/asic/Makefile:ccflags-y := -Wall -Werror
powertv/pci/Makefile:ccflags-y := -Wall -Werror
There seems to be some need to clean this up.
I guess for now you will need to drop the W=1 to build an image.
I will talk to Ralf about this.
Thanks,
John
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-03-09 10:59 ` John Crispin
@ 2012-03-09 11:16 ` Artem Bityutskiy
0 siblings, 0 replies; 9+ messages in thread
From: Artem Bityutskiy @ 2012-03-09 11:16 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse, Ralf Baechle
On Fri, 2012-03-09 at 11:59 +0100, John Crispin wrote:
> On 09/03/12 09:40, Artem Bityutskiy wrote:
> > I would like to compile-test this patch. I've got this error when
> > compiling with mips-linux-gcc-4.6.0 and the attached defconfig:
> >
> > from include/linux/sched.h:55,
> > from arch/mips/kernel/asm-offsets.c:13:
> > include/linux/bitops.h: In function 'hweight_long':
> > include/linux/bitops.h:55:26: warning: signed and unsigned type in conditional expression [-Wsign-compare]
> > arch/mips/kernel/asm-offsets.c: At top level:
> > arch/mips/kernel/asm-offsets.c:21:6: warning: no previous prototype for 'output_ptreg_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:76:6: warning: no previous prototype for 'output_task_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:88:6: warning: no previous prototype for 'output_thread_info_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:105:6: warning: no previous prototype for 'output_thread_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:136:6: warning: no previous prototype for 'output_thread_fpu_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:175:6: warning: no previous prototype for 'output_mm_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:211:6: warning: no previous prototype for 'output_sc_defines' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:257:6: warning: no previous prototype for 'output_signal_defined' [-Wmissing-prototypes]
> > arch/mips/kernel/asm-offsets.c:295:6: warning: no previous prototype for 'output_irq_cpustat_t_defines' [-Wmissing-prototypes]
> > In file included from include/linux/kernel.h:17:0,
> > from arch/mips/kernel/cpu-probe.c:15:
> > include/linux/bitops.h: In function 'hweight_long':
> > include/linux/bitops.h:55:26: error: signed and unsigned type in conditional expression [-Werror=sign-compare]
> > arch/mips/kernel/cpu-probe.c: At top level:
> > arch/mips/kernel/cpu-probe.c:64:6: error: no previous prototype for 'r4k_wait_irqoff' [-Werror=missing-prototypes]
> > arch/mips/kernel/cpu-probe.c:154:13: error: no previous prototype for 'check_wait' [-Werror=missing-prototypes]
> > cc1: all warnings being treated as errors
> >
> > I use W=1 when compiling. Any suggestions?
>
> Hi,
>
> just tried 4.5 where the same happens. The errors don't seem to have
> been introduced by 4.6.
>
> apart from that the -Werror is set by arch/mips/ as follows
> bcm63xx/boards/Makefile:ccflags-y := -Werror
> fw/arc/Makefile:ccflags-y := -Werror
> jz4740/Makefile:ccflags-y := -Werror -Wall
> Kbuild:subdir-ccflags-y := -Werror
> oprofile/Makefile:ccflags-y := -Werror
> pmc-sierra/yosemite/Makefile:ccflags-y := -Werror
> powertv/asic/Makefile:ccflags-y := -Wall -Werror
> powertv/pci/Makefile:ccflags-y := -Wall -Werror
>
> There seems to be some need to clean this up.
> I guess for now you will need to drop the W=1 to build an image.
I believe mips should either fix all warnings or remove -Werror. Indeed,
I have build-check scripts which work fine for many architectures with
W=1, but not for mips, and from my POW introducing exceptions for mips
is inconsistent.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-03-09 8:58 ` John Crispin
2012-03-09 9:08 ` Artem Bityutskiy
@ 2012-03-09 11:09 ` Artem Bityutskiy
1 sibling, 0 replies; 9+ messages in thread
From: Artem Bityutskiy @ 2012-03-09 11:09 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse
On Fri, 2012-03-09 at 09:58 +0100, John Crispin wrote:
> i have tested this patch using arch/mips/configs/xway_defconfig and
This defconfig is not in upstream AFAICS.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-02-23 16:59 [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions John Crispin
2012-03-09 8:40 ` Artem Bityutskiy
@ 2012-03-09 11:27 ` Artem Bityutskiy
2012-03-09 11:29 ` John Crispin
1 sibling, 1 reply; 9+ messages in thread
From: Artem Bityutskiy @ 2012-03-09 11:27 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse
On Thu, 2012-02-23 at 17:59 +0100, John Crispin wrote:
> From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>
> Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
> command line parsing of MTD partitions does not work anymore.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
> Signed-off-by: John Crispin <blogic@openwrt.org>
Pushed to l2-mtd.git and added:
Cc: stable@kernel.org [3.2+]
since this is a regression. Please, confirm that CCing the stable tree
is fine with you.
Thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions
2012-03-09 11:27 ` Artem Bityutskiy
@ 2012-03-09 11:29 ` John Crispin
0 siblings, 0 replies; 9+ messages in thread
From: John Crispin @ 2012-03-09 11:29 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, Daniel Schwierzeck, David Woodhouse
On 09/03/12 12:27, Artem Bityutskiy wrote:
> On Thu, 2012-02-23 at 17:59 +0100, John Crispin wrote:
>> From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>>
>> Since commit ca97dec2ab5c87e9fbdf7e882e1820004a3966fa the
>> command line parsing of MTD partitions does not work anymore.
>>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
> Pushed to l2-mtd.git and added:
> Cc: stable@kernel.org [3.2+]
>
> since this is a regression. Please, confirm that CCing the stable tree
> is fine with you.
Acked-by: John Crispin <blogic@openwrt.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-09 11:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 16:59 [PATCH] MTD: MIPS: lantiq: reintroduce support for cmdline partitions John Crispin
2012-03-09 8:40 ` Artem Bityutskiy
2012-03-09 8:58 ` John Crispin
2012-03-09 9:08 ` Artem Bityutskiy
2012-03-09 10:59 ` John Crispin
2012-03-09 11:16 ` Artem Bityutskiy
2012-03-09 11:09 ` Artem Bityutskiy
2012-03-09 11:27 ` Artem Bityutskiy
2012-03-09 11:29 ` John Crispin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox