* [PATCH V2 1/3] MTD: MIPS: lantiq: use module_platform_driver inside lantiq map driver
@ 2012-02-23 16:03 John Crispin
2012-03-09 11:28 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: John Crispin @ 2012-02-23 16:03 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-mtd, John Crispin
Reduce boilerplate code by converting driver to module_platform_driver.
Signed-off-by: John Crispin <blogic@openwrt.org>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/maps/lantiq-flash.c | 22 +++-------------------
1 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/mtd/maps/lantiq-flash.c b/drivers/mtd/maps/lantiq-flash.c
index 7b889de..395ebfe 100644
--- a/drivers/mtd/maps/lantiq-flash.c
+++ b/drivers/mtd/maps/lantiq-flash.c
@@ -107,7 +107,7 @@ ltq_copy_to(struct map_info *map, unsigned long to,
spin_unlock_irqrestore(&ebu_lock, flags);
}
-static int __init
+static int __devinit
ltq_mtd_probe(struct platform_device *pdev)
{
struct physmap_flash_data *ltq_mtd_data = dev_get_platdata(&pdev->dev);
@@ -203,6 +203,7 @@ ltq_mtd_remove(struct platform_device *pdev)
}
static struct platform_driver ltq_mtd_driver = {
+ .probe = ltq_mtd_probe,
.remove = __devexit_p(ltq_mtd_remove),
.driver = {
.name = "ltq_nor",
@@ -210,24 +211,7 @@ static struct platform_driver ltq_mtd_driver = {
},
};
-static int __init
-init_ltq_mtd(void)
-{
- int ret = platform_driver_probe(<q_mtd_driver, ltq_mtd_probe);
-
- if (ret)
- pr_err("ltq_nor: error registering platform driver");
- return ret;
-}
-
-static void __exit
-exit_ltq_mtd(void)
-{
- platform_driver_unregister(<q_mtd_driver);
-}
-
-module_init(init_ltq_mtd);
-module_exit(exit_ltq_mtd);
+module_platform_driver(ltq_mtd_driver);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("John Crispin <blogic@openwrt.org>");
--
1.7.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2 1/3] MTD: MIPS: lantiq: use module_platform_driver inside lantiq map driver
2012-02-23 16:03 [PATCH V2 1/3] MTD: MIPS: lantiq: use module_platform_driver inside lantiq map driver John Crispin
@ 2012-03-09 11:28 ` Artem Bityutskiy
2012-03-09 11:29 ` John Crispin
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2012-03-09 11:28 UTC (permalink / raw)
To: John Crispin; +Cc: linux-mips, linux-mtd, Ralf Baechle
On Thu, 2012-02-23 at 17:03 +0100, John Crispin wrote:
> Reduce boilerplate code by converting driver to module_platform_driver.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> Cc: linux-mtd@lists.infradead.org
This is not an independent patch - do you want to merge it via the mips
tree?
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2 1/3] MTD: MIPS: lantiq: use module_platform_driver inside lantiq map driver
2012-03-09 11:28 ` Artem Bityutskiy
@ 2012-03-09 11:29 ` John Crispin
0 siblings, 0 replies; 3+ messages in thread
From: John Crispin @ 2012-03-09 11:29 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mips, linux-mtd, Ralf Baechle
On 09/03/12 12:28, Artem Bityutskiy wrote:
> On Thu, 2012-02-23 at 17:03 +0100, John Crispin wrote:
>> Reduce boilerplate code by converting driver to module_platform_driver.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> Cc: linux-mtd@lists.infradead.org
> This is not an independent patch - do you want to merge it via the mips
> tree?
>
via MIPS, sorry for not putting the info in the commit text
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-09 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 16:03 [PATCH V2 1/3] MTD: MIPS: lantiq: use module_platform_driver inside lantiq map driver John Crispin
2012-03-09 11:28 ` Artem Bityutskiy
2012-03-09 11:29 ` John Crispin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox