From: Armando Visconti <armando.visconti@st.com>
To: "dedekind1@gmail.com" <dedekind1@gmail.com>
Cc: Vipin KUMAR <vipin.kumar@st.com>,
"Artem.Bityutskiy@nokia.com" <Artem.Bityutskiy@nokia.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>
Subject: Re: [PATCH 08/18] fsmc/nand: Add support for default partitions for several NAND devices
Date: Fri, 9 Mar 2012 15:47:57 +0100 [thread overview]
Message-ID: <4F5A181D.1080106@st.com> (raw)
In-Reply-To: <1331298422.29445.23.camel@sauron.fi.intel.com>
On 03/09/2012 02:07 PM, Artem Bityutskiy wrote:
> On Wed, 2012-03-07 at 17:00 +0530, Vipin Kumar wrote:
>> +static struct mtd_partition partition_info_64KB_blk[] = {
>> + {
>> + .name = "X-loader",
>> + .offset = 0,
>> + .size = 4*0x10000,
>> + },
>> + {
>> + .name = "U-Boot",
>> + .offset = 4*0x10000,
>> + .size = 8*0x40000,
>> + },
>> + {
>> + .name = "Kernel",
>> + .offset = (4+8)*0x10000,
>> + .size = 64*0x40000,
>> + },
>> + {
>> + .name = "Root File System",
>> + .offset = (4+8+64)*0x10000,
>> + .size = MTDPART_SIZ_FULL,
>> + },
>> +};
>
> Shouldn't this kind of data come from DT/platform data or cmdline
> instead? Does it make sense to have it hard-coded in the driver?
>
These are just the default partitions.
We are passing them also from platform, and it is possible also
from cmdline.
But in case we don't, this is the default.
Shouldn't we treat such a case?
Ciao,
Arm
next prev parent reply other threads:[~2012-03-09 14:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 11:30 [PATCH 00/18] mtd/nand/fsmc related modifications Vipin Kumar
2012-03-07 11:30 ` [PATCH 01/18] nand/fsmc: Newly erased page read algorithm implemented Vipin Kumar
2012-03-07 15:10 ` Linus Walleij
2012-03-07 11:30 ` [PATCH 02/18] mtd/fsmc_nand: ECC1 & ECC4 layout separated for different page sizes Vipin Kumar
2012-03-07 11:30 ` [PATCH 03/18] nand/fsmc: use ALE and CLE offsets from platform data Vipin Kumar
2012-03-07 11:30 ` [PATCH 04/18] mtd/nand/fsmc: Move ALE, CLE defines to their respective platform Vipin Kumar
2012-03-07 11:30 ` [PATCH 05/18] fsmc_nand.c: Fixed data abort inside change_bit() Vipin Kumar
2012-03-07 11:30 ` [PATCH 06/18] nand/fsmc: Improve the fsmc_correct_data() routine Vipin Kumar
2012-03-07 11:30 ` [PATCH 07/18] fsmc_nand.c: Support of 224-bytes OOB area length Vipin Kumar
2012-03-07 11:30 ` [PATCH 08/18] fsmc/nand: Add support for default partitions for several NAND devices Vipin Kumar
2012-03-09 13:07 ` Artem Bityutskiy
2012-03-09 14:47 ` Armando Visconti [this message]
2012-03-09 15:11 ` Artem Bityutskiy
2012-03-13 9:53 ` Armando Visconti
2012-03-13 10:34 ` Vipin Kumar
2012-03-13 11:56 ` Linus Walleij
2012-03-13 12:39 ` Linus Walleij
2012-03-13 12:45 ` Artem Bityutskiy
2012-03-13 12:53 ` Stefan Roese
2012-03-13 13:01 ` Linus Walleij
2012-03-13 13:19 ` Artem Bityutskiy
2012-03-13 13:36 ` Stefan Roese
2012-03-13 14:07 ` Artem Bityutskiy
2012-03-14 6:33 ` Vipin Kumar
2012-03-14 7:10 ` Stefan Roese
2012-03-14 8:22 ` Vipin Kumar
2012-03-14 8:57 ` Linus Walleij
2012-03-14 11:02 ` Artem Bityutskiy
2012-03-14 11:05 ` Linus Walleij
2012-03-13 12:49 ` Stefan Roese
2012-03-07 11:30 ` [PATCH 09/18] nand/fsmc: Correct the multiline comment format Vipin Kumar
2012-03-07 11:30 ` [PATCH 10/18] nand/fsmc: Read only 512 + 13 bytes for 8bit NAND devices Vipin Kumar
2012-03-07 11:30 ` [PATCH 11/18] nand/fsmc: Flip the bit only if the error index is < 4096 Vipin Kumar
2012-03-07 11:31 ` [PATCH 12/18] nand/fsmc: Initialize the badblockbits to 7 Vipin Kumar
2012-03-07 11:31 ` [PATCH 13/18] mtd/fsmc_nand: add pm callbacks to support hibernation Vipin Kumar
2012-03-07 11:31 ` [PATCH 14/18] fsmc/nand: Modify fsmc driver to accept nand timing parameters via platform Vipin Kumar
2012-03-07 11:31 ` [PATCH 15/18] fsmc/nand: Use devm routines Vipin Kumar
2012-03-07 11:31 ` [PATCH 16/18] fsmc/nand: Use dev_err to report error scenario Vipin Kumar
2012-03-07 11:31 ` [PATCH 17/18] fsmc/nand: Access the NAND device word by word whenever possible Vipin Kumar
2012-03-07 11:31 ` [PATCH 18/18] fsmc/nand: Add DMA support Vipin Kumar
2012-03-07 16:09 ` Linus Walleij
2012-03-09 9:42 ` Vipin Kumar
2012-03-09 9:55 ` Vipin Kumar
2012-03-07 11:52 ` [PATCH 00/18] mtd/nand/fsmc related modifications Vipin Kumar
2012-03-09 13:20 ` Artem Bityutskiy
2012-03-09 13:26 ` Artem Bityutskiy
2012-03-14 6:21 ` Vipin Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A181D.1080106@st.com \
--to=armando.visconti@st.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=dedekind1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vipin.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).