From: Mike Dunn <mikedunn@newsguy.com>
To: dedekind1@gmail.com
Cc: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH 4/4] MTD: drivers return max_bitflips, mtd returns -EUCLEAN
Date: Fri, 30 Mar 2012 18:17:33 -0700 [thread overview]
Message-ID: <4F765B2D.5040604@newsguy.com> (raw)
In-Reply-To: <1333109630.5440.18.camel@sauron.fi.intel.com>
On 03/30/2012 05:13 AM, Artem Bityutskiy wrote:
> On Thu, 2012-03-29 at 10:30 -0700, Brian Norris wrote:
>> Did you test any non-NAND devices? I'm getting the feeling that some
>> of this is misguided or at least needs some fixing. See below.
>
> you are right, these 2 should be reverted and Mike should come back with
> a better patch-set. I was not careful enough, and thanks for the review.
At least you were not the author. Yes, thank you Brian.
Artem, I don't think you pushed the offending patches (3 and 4). If you want to
leave the first two patches in, I'll be happy to fix them (they currently don't
do anything) when the whole efort is done. Or else you can pull them and I'll
start from scratch. Or slink away in shame :) But I'd prefer to get this done
right.
Mike
next prev parent reply other threads:[~2012-03-31 1:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 21:21 [PATCH 0/4] MTD: Change meaning of -EUCLEAN return code on reads Mike Dunn
2012-03-11 21:21 ` [PATCH 1/4] MTD: add ecc_strength fields to mtd structs Mike Dunn
2012-03-13 12:25 ` Artem Bityutskiy
2012-03-11 21:21 ` [PATCH 2/4] MTD: flash drivers set ecc strength Mike Dunn
2012-03-13 12:27 ` Artem Bityutskiy
2012-03-16 14:13 ` Ivan Djelic
2012-03-16 20:02 ` Mike Dunn
2012-03-29 17:24 ` Brian Norris
2012-03-31 0:05 ` Mike Dunn
2012-04-02 17:34 ` Mike Dunn
2012-04-03 8:03 ` Ivan Djelic
2012-03-11 21:21 ` [PATCH 3/4] MTD: euclean_threshold added to mtd_info and sysfs Mike Dunn
2012-03-13 12:29 ` Artem Bityutskiy
2012-03-11 21:21 ` [PATCH 4/4] MTD: drivers return max_bitflips, mtd returns -EUCLEAN Mike Dunn
2012-03-14 11:05 ` Shmulik Ladkani
2012-03-14 11:45 ` Shmulik Ladkani
2012-03-29 17:30 ` Brian Norris
2012-03-30 12:13 ` Artem Bityutskiy
2012-03-31 1:17 ` Mike Dunn [this message]
2012-04-02 7:17 ` Artem Bityutskiy
2012-04-02 15:33 ` Mike Dunn
2012-03-31 1:05 ` Mike Dunn
2012-03-31 6:37 ` Shmulik Ladkani
2012-04-02 16:40 ` Mike Dunn
2012-04-03 8:48 ` Shmulik Ladkani
2012-04-13 15:54 ` Artem Bityutskiy
2012-04-13 18:18 ` Mike Dunn
2012-03-13 12:03 ` [PATCH 0/4] MTD: Change meaning of -EUCLEAN return code on reads Artem Bityutskiy
2012-03-13 17:46 ` Mike Dunn
2012-03-13 22:14 ` Mike Dunn
2012-03-14 10:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F765B2D.5040604@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=David.Woodhouse@intel.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).