From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from co202.xi-lite.net ([149.6.83.202]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SK3BL-0007CJ-Jh for linux-mtd@lists.infradead.org; Tue, 17 Apr 2012 07:50:36 +0000 Message-ID: <4F8D20C4.9010607@parrot.com> Date: Tue, 17 Apr 2012 09:50:28 +0200 From: Matthieu CASTET MIME-Version: 1.0 To: Brian Norris Subject: Re: [PATCH 1/2] mtd: nand: add OOB argument to NAND {read, write}_page interfaces References: <1334615755-15418-1-git-send-email-computersforpeace@gmail.com> <1334615755-15418-2-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1334615755-15418-2-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Cc: Viresh Kumar , Artem Bityutskiy , Nicolas Ferre , Vipin Kumar , "linux-mtd@lists.infradead.org" , Laurent Pinchart , Florian Fainelli , Lei Wen , Jamie Iles , Mike Dunn , Dmitry Eremin-Solenikov , Kevin Cernekee , Bastian Hecht , Axel Lin , Li Yang , Jean-Christophe PLAGNIOL-VILLARD , Armando Visconti , Liu Shuo , Thomas Gleixner , Scott Branden , Artem Bityutskiy , Wolfram Sang , Huang Shijie , Shmulik Ladkani , Jiandong Zheng , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Brian Norris a écrit : > New NAND controllers can perform read/write via HW engines which don't expose > OOB data in their DMA mode. To reflect this, we should rework the nand_chip / > nand_ecc_ctrl interfaces that assume that drivers will always read/write OOB > data in the nand_chip.oob_poi buffer. A better interface would pass the > appropriate buffer explicitly when OOB data is requested and otherwise pass a > NULL pointer, meaning that no OOB data is needed. If I understand correctly you propose that these driver will fetch oob (via pio mode) only when needed ? Do you have an example of such controller ? Matthieu