From: Scott Wood <scottwood@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Li Yang <leoli@freescale.com>,
linux-mtd@lists.infradead.org,
Prabhakar Kushwaha <prabhakar@freescale.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v3 07/10] mtd: IFC NAND: utilize oob_required parameter
Date: Mon, 30 Apr 2012 14:13:09 -0500 [thread overview]
Message-ID: <4F9EE445.6010402@freescale.com> (raw)
In-Reply-To: <CAN8TOE_3kSPhNUN7ETaBDkqvFC9=4xxFLa6O5s-zsCsqEwG4cg@mail.gmail.com>
On 04/30/2012 02:08 PM, Brian Norris wrote:
> On Mon, Apr 30, 2012 at 9:43 AM, Scott Wood <scottwood@freescale.com> wrote:
>> On 04/27/2012 08:29 PM, Brian Norris wrote:
>>> @@ -717,7 +718,8 @@ static void fsl_ifc_write_page(struct mtd_info *mtd, struct nand_chip *chip,
>>> const uint8_t *buf, int oob_required)
>>> {
>>> fsl_ifc_write_buf(mtd, buf, mtd->writesize);
>>> - fsl_ifc_write_buf(mtd, chip->oob_poi, mtd->oobsize);
>>> + if (oob_required)
>>> + fsl_ifc_write_buf(mtd, chip->oob_poi, mtd->oobsize);
>>> }
>>
>> This will result in writing junk to the non-ECC OOB bytes as opposed to
>> leaving it alone.
>
> Then I'll drop the write_page change from this patch.
>
> Is the read_page change sane?
It should be harmless.
> Did you review the (misspelled) eLBC patch? (patch 06/10)
No, that one wasn't CCed to me (I should probably get around to
subscribing to linux-mtd...). It looks like the same situation as IFC.
-Scott
next prev parent reply other threads:[~2012-04-30 19:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 1:29 [PATCH v3 00/10] mtd: nand: rework nand_ecc_ctrl interface for OOB Brian Norris
2012-04-28 1:29 ` [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read, write}_page interfaces Brian Norris
2012-04-29 11:36 ` [PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read,write}_page interfaces Shmulik Ladkani
2012-04-29 13:25 ` Artem Bityutskiy
2012-04-30 19:16 ` Brian Norris
2012-04-30 19:21 ` Scott Wood
2012-04-28 1:29 ` [PATCH v3 02/10] mtd: nand: pass proper 'oob_required' parameter Brian Norris
2012-04-29 11:41 ` Shmulik Ladkani
2012-04-28 1:29 ` [PATCH v3 03/10] mtd: Blackfin NFC: utilize oob_required parameter Brian Norris
2012-04-28 1:29 ` [PATCH v3 04/10] mtd: cafe_nand: " Brian Norris
2012-04-28 1:29 ` [PATCH v3 05/10] mtd: denali: " Brian Norris
2012-04-28 1:29 ` [PATCH v3 06/10] mtd: eLBD NAND: " Brian Norris
2012-04-28 1:29 ` [PATCH v3 07/10] mtd: IFC " Brian Norris
2012-04-30 16:43 ` Scott Wood
2012-04-30 19:08 ` Brian Norris
2012-04-30 19:13 ` Scott Wood [this message]
2012-04-30 19:23 ` Brian Norris
2012-04-30 19:32 ` Scott Wood
2012-04-28 1:29 ` [PATCH v3 08/10] mtd: gpmi-nand: utilize oob_requested parameter Brian Norris
2012-04-28 2:32 ` Huang Shijie
2012-04-28 1:29 ` [PATCH v3 09/10] mtd: nand: utilize oob_required parameter Brian Norris
2012-04-29 12:47 ` Shmulik Ladkani
2012-04-30 19:59 ` Brian Norris
2012-04-30 20:12 ` Brian Norris
2012-04-30 20:21 ` Scott Wood
2012-04-30 21:49 ` Brian Norris
2012-05-01 12:12 ` Artem Bityutskiy
2012-05-01 8:29 ` Shmulik Ladkani
2012-04-28 1:29 ` [PATCH v3 10/10] mtd: pxa3xx_nand: " Brian Norris
2012-04-30 7:10 ` [PATCH v3 00/10] mtd: nand: rework nand_ecc_ctrl interface for OOB Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9EE445.6010402@freescale.com \
--to=scottwood@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=leoli@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=prabhakar@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).