From: Richard Weinberger <richard@nod.at>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: tglx@linutronix.de, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] UBI: Kill data type hint
Date: Sun, 13 May 2012 17:28:38 +0200 [thread overview]
Message-ID: <4FAFD326.4020406@nod.at> (raw)
In-Reply-To: <1336920094.2003.20.camel@koala>
Am 13.05.2012 16:41, schrieb Artem Bityutskiy:
> Hi Richard,
>
> On Fri, 2012-05-11 at 14:14 +0200, Richard Weinberger wrote:
>> struct ubi_map_req {
>> __s32 lnum;
>> - __s8 dtype;
>> - __s8 padding[3];
>> + __s8 padding[4];
>> } __packed;
>
>
> The "dtype" field is part of ABI, and merging it with padding is bad
> because padding holds "free" fields, which can be used in future. But
> "dtype" is not really free. I think it should stay here. You should put
> a comment explaining that it was used in the past for this and that, but
> now unused and ignored by UBI. Probably a date when we stopped using it
> would also be good.
Oh, it's ABI. Then I'll keep it and mark it as obsolete.
> May be it even deserves to be in a separate patches for this one and
> ubi_leb_change_req ?
Indeed.
Thanks,
//richard
next prev parent reply other threads:[~2012-05-13 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 12:14 [RFC] UBI: Kill data type hint Richard Weinberger
2012-05-11 12:14 ` [PATCH] " Richard Weinberger
2012-05-13 14:41 ` Artem Bityutskiy
2012-05-13 15:28 ` Richard Weinberger [this message]
2012-05-13 14:26 ` Artem Bityutskiy
2012-05-13 14:37 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAFD326.4020406@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).