From: Tomer Barletz <barletz@gmail.com>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] mtd-utils: Check mtdoffset is not larger than mtd.size in case of a bad block.
Date: Tue, 26 Jun 2012 14:46:41 -0700 [thread overview]
Message-ID: <4FEA2DC1.9090003@gmail.com> (raw)
mtdoffset is being tested against mtd.size in the outer two loops, but
the third nested one does not test against it.
In case of a bad block we'll try to access an out of bounds offset in
the next MEMGETBADBLOCK ioctl, which will fail with EINVAL.
In case mtdoffset is indeed larger than the partition size, we need to
bail, since there are not enough "good" blocks to complete the write.
Signed-off-by: Tomer Barletz <barletz@gmail.com>
---
nandwrite.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/nandwrite.c b/nandwrite.c
index a42f7c9..8bd00c1 100644
--- a/nandwrite.c
+++ b/nandwrite.c
@@ -399,6 +399,11 @@ int main(int argc, char * const argv[])
if (baderaseblock) {
mtdoffset = blockstart + ebsize_aligned;
+
+ if (mtdoffset > mtd.size) {
+ perror("Too many bad blocks - cannot complete request.");
+ goto closeall;
+ }
}
offs += ebsize_aligned / blockalign;
} while (offs < blockstart + ebsize_aligned);
--
1.7.1
--Tomer
next reply other threads:[~2012-06-26 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 21:46 Tomer Barletz [this message]
2012-06-29 8:32 ` [PATCH] mtd-utils: Check mtdoffset is not larger than mtd.size in case of a bad block Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEA2DC1.9090003@gmail.com \
--to=barletz@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox