From: Adrian Hunter <adrian.hunter@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: question about fs/ubifs/orphan.c
Date: Mon, 09 Jul 2012 09:46:56 +0300 [thread overview]
Message-ID: <4FFA7E60.8060404@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1207081122250.2436@localhost6.localdomain6>
On 08/07/12 12:22, Julia Lawall wrote:
> There is another occurrence of the same pattern in the function consolidate
> in the same file.
Yes. It needs the same fix. Will you send a patch?
>
> julia
>
> On Sun, 8 Jul 2012, Julia Lawall wrote:
>
>> The function ubifs_orphan_start_commit contains the code:
>>
>> list_for_each_entry(orphan, &c->orph_new, new_list) {
>> ubifs_assert(orphan->new);
>> orphan->new = 0;
>> *last = orphan;
>> last = &orphan->cnext;
>> }
>> *last = orphan->cnext;
>>
>> After list_for_each_entry, orphan is just an address at an offset from the
>> list head, not a pointer to a real structure. So it does not seem correct
>> to access its cnext field.
>>
>> julia
>>
>
>
next prev parent reply other threads:[~2012-07-09 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 9:21 question about fs/ubifs/orphan.c Julia Lawall
2012-07-08 9:22 ` Julia Lawall
2012-07-09 6:46 ` Adrian Hunter [this message]
2012-07-09 7:21 ` Julia Lawall
2012-07-08 12:40 ` Artem Bityutskiy
2012-07-08 13:06 ` Julia Lawall
2012-07-09 6:47 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFA7E60.8060404@intel.com \
--to=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox