From: Michael Walle <michael@walle.cc>
To: Fabio Estevam <festevam@gmail.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
pratyush@kernel.org, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, linux-mtd@lists.infradead.org,
Fabio Estevam <festevam@denx.de>,
tkuw584924@gmail.com
Subject: Re: [PATCH] mtd: spi-nor: micron-st: Add support for mt25qu01g
Date: Tue, 24 Oct 2023 18:36:52 +0200 [thread overview]
Message-ID: <4e2de38da5a3e492eac522b9a68141c7@walle.cc> (raw)
In-Reply-To: <CAOMZO5AOfVAcap74kBH8qbf53LKWXN60ML32t1nBG8OOoUPkjQ@mail.gmail.com>
Am 2023-10-24 18:20, schrieb Fabio Estevam:
> On Tue, Oct 24, 2023 at 12:53 PM Tudor Ambarus
> <tudor.ambarus@linaro.org> wrote:
>
>> drivers/mtd/spi-nor/sfdp.c, search for n_dice. spi_nor_parse_sccr_mc()
>
> On my tests, spi_nor_parse_sccr_mc() never gets called.
>
> In the 'switch (SFDP_PARAM_HEADER_ID(param_header))' the following
> case is reached.
>
> case SFDP_4BAIT_ID:
> err = spi_nor_parse_4bait(nor, param_header);
> break;
>
> so spi_nor_parse_sccr_mc() does not run.
>
> What should be done to get spi_nor_parse_sccr_mc() called?
Mhh, that's a pity. It seems that your SFDP in the flash doesn't
contain that table. I haven't confirmed it by looking at your dump
as I'm about to go on vacation tomorrow and packing right now.
What do we do in that case, Tudor? I presume a fixup which sets n_dice
(any maybe others) to the correct value?
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-10-24 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 21:38 [PATCH] mtd: spi-nor: micron-st: Add support for mt25qu01g Fabio Estevam
2023-10-24 6:01 ` Tudor Ambarus
2023-10-24 13:57 ` Fabio Estevam
2023-10-24 14:23 ` Tudor Ambarus
2023-10-24 9:26 ` Michael Walle
2023-10-24 11:43 ` Fabio Estevam
2023-10-24 13:59 ` Michael Walle
2023-10-24 15:47 ` Fabio Estevam
2023-10-24 15:53 ` Tudor Ambarus
2023-10-24 16:20 ` Fabio Estevam
2023-10-24 16:36 ` Michael Walle [this message]
2023-10-24 16:43 ` Fabio Estevam
2023-10-25 3:34 ` Tudor Ambarus
2023-10-25 11:56 ` Fabio Estevam
2023-10-25 17:35 ` Fabio Estevam
2023-10-26 6:33 ` Michael Walle
2023-10-26 11:25 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e2de38da5a3e492eac522b9a68141c7@walle.cc \
--to=michael@walle.cc \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tkuw584924@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox