From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6222C48BC4 for ; Tue, 13 Feb 2024 10:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pDwyAcSECUrij0jaKJY696uCXS6LC+TQmApaFDBhjN4=; b=MaYI8WX5nl8Qih aGcOpdwQTadWxQedI5cjRy7vo9kn1JsuJQxDKM3jX5mupu4RnVjo0hpFXazX/8uZkQrz94oLC8x+v UpP6uXw/vJAU/5nPWtSkIFs/UEMdoDkIkrSsoXOCM4rFOukdzgqPCLpzSrdGwIPl46PDM90ChBAF+ QopHK75SZPRCCYYHqf6Qid68tp7pYq1q+3bk4mtXhJtn0Ta6mjIEwWX4T+IblDw7ufix9myzcxNhS 2lmjeZIuMmEtCRq07Unegn/QzyD+90DNYpcL7x69hU2znZIZHJWRQAsWGbhhpa6+QO773H3Uuin/A Q4oDY0AJkUyaiTTPRBLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZqUZ-00000008v39-2VcA; Tue, 13 Feb 2024 10:58:23 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZqUT-00000008uyR-3pXz for linux-mtd@lists.infradead.org; Tue, 13 Feb 2024 10:58:20 +0000 Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41DA9Si1026396; Tue, 13 Feb 2024 11:58:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=1J5ztYg9uk0Ni/zb1+iLOfL8R7ELBVGeERYFdVqxo4k=; b=4l KeigsmJRyRSZpDB1GGpZeGwsU+pxVgR5svCf0mUhv4HRWOKBopyE/cjDw8pfG5MY 1X/2MSOr7n3mRjNQ4NCjlj0G24eGjJ2rCmnGP94JlQYEtqJmvPV472r8hkSgONFp sOo1C7E6uory1zMAPzC6LkjgG/RvRdi6CwwfAMBRhwfyxj3HiY+yDWtvpexGvAst NNhTjTGSq/P52etuCNGLWx27555zq/dpT4S5P07XC7thxZfm2zHYxq+ztRFYnQk8 MZn4FFIxbLMYVjkziRIhgZHwuJPJ9Im66MWQugZk92r3V8+t+R2esBoS7GlcRCz/ RykY3g4r9eUJq1U4xnIA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3w6kk4r3h2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 11:58:08 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 5C7D140049; Tue, 13 Feb 2024 11:58:05 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 0E12A22D19E; Tue, 13 Feb 2024 11:57:28 +0100 (CET) Received: from [10.201.22.200] (10.201.22.200) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 13 Feb 2024 11:57:27 +0100 Message-ID: <4ec4a926-fd1c-44e7-990b-4af0e09b9224@foss.st.com> Date: Tue, 13 Feb 2024 11:57:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/12] dt-bindings: mtd: st,stm32: add MP25 support Content-Language: en-US To: Conor Dooley CC: , , , , , , , , , , References: <20240212174822.77734-1-christophe.kerello@foss.st.com> <20240212174822.77734-9-christophe.kerello@foss.st.com> <20240212-squeak-mortality-5a53a4d1039c@spud> From: Christophe Kerello In-Reply-To: <20240212-squeak-mortality-5a53a4d1039c@spud> X-Originating-IP: [10.201.22.200] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_05,2024-02-12_03,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_025818_308592_A227FE46 X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 2/12/24 19:38, Conor Dooley wrote: > On Mon, Feb 12, 2024 at 06:48:18PM +0100, Christophe Kerello wrote: >> Add 2 new compatible strings to support MP25 SOC. >> MP25 SOC supports up to 4 chip select. > > Again, please explain why the new device is not compatible with the > existing ones. Also, please explain why two compatibles are required for > the mp25. > Hi Conor, FMC2 IP supports up to 4 chip select. On MP1 SoC, only 2 of them are available when on MP25 SoC, the 4 chip select are available. MP1 SoC also embeds revision 1.1 of the FMC2 IP when MP25 SoC embeds revision 2.0 of the FMC2 IP. I will add this explanation in the commit message. Regards, Christophe Kerello. > Thanks, > Conor. > >> >> Signed-off-by: Christophe Kerello >> --- >> .../bindings/mtd/st,stm32-fmc2-nand.yaml | 58 ++++++++++++++++++- >> 1 file changed, 57 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml b/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml >> index e72cb5bacaf0..33a753c8877b 100644 >> --- a/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml >> +++ b/Documentation/devicetree/bindings/mtd/st,stm32-fmc2-nand.yaml >> @@ -14,10 +14,12 @@ properties: >> enum: >> - st,stm32mp15-fmc2 >> - st,stm32mp1-fmc2-nfc >> + - st,stm32mp25-fmc2 >> + - st,stm32mp25-fmc2-nfc >> >> reg: >> minItems: 6 >> - maxItems: 7 >> + maxItems: 13 >> >> interrupts: >> maxItems: 1 >> @@ -92,6 +94,60 @@ allOf: >> - description: Chip select 1 command >> - description: Chip select 1 address space >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: st,stm32mp25-fmc2 >> + then: >> + properties: >> + reg: >> + items: >> + - description: Registers >> + - description: Chip select 0 data >> + - description: Chip select 0 command >> + - description: Chip select 0 address space >> + - description: Chip select 1 data >> + - description: Chip select 1 command >> + - description: Chip select 1 address space >> + - description: Chip select 2 data >> + - description: Chip select 2 command >> + - description: Chip select 2 address space >> + - description: Chip select 3 data >> + - description: Chip select 3 command >> + - description: Chip select 3 address space >> + >> + clocks: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> + required: >> + - clocks >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: st,stm32mp25-fmc2-nfc >> + then: >> + properties: >> + reg: >> + items: >> + - description: Chip select 0 data >> + - description: Chip select 0 command >> + - description: Chip select 0 address space >> + - description: Chip select 1 data >> + - description: Chip select 1 command >> + - description: Chip select 1 address space >> + - description: Chip select 2 data >> + - description: Chip select 2 command >> + - description: Chip select 2 address space >> + - description: Chip select 3 data >> + - description: Chip select 3 command >> + - description: Chip select 3 address space >> + >> required: >> - compatible >> - reg >> -- >> 2.25.1 >> ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/