From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wj0-x241.google.com ([2a00:1450:400c:c01::241]) by merlin.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cOpH4-0000Pe-CO for linux-mtd@lists.infradead.org; Wed, 04 Jan 2017 17:22:54 +0000 Received: by mail-wj0-x241.google.com with SMTP id hb5so43170819wjc.2 for ; Wed, 04 Jan 2017 09:22:33 -0800 (PST) Subject: Re: [PATCH v4 10/15] mtd: nand: move Micron specific init logic in nand_micron.c To: Boris Brezillon References: <1483448495-31607-1-git-send-email-boris.brezillon@free-electrons.com> <1483448495-31607-11-git-send-email-boris.brezillon@free-electrons.com> <51f2f7a3-56a7-1117-ab15-dd8eb59a4373@gmail.com> <20170104181314.4f9a0c40@bbrezillon> Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Cyrille Pitchen , Icenowy Zheng , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <4f82a1e8-be0b-4dd5-f26e-b97af80029cd@gmail.com> Date: Wed, 4 Jan 2017 18:22:31 +0100 MIME-Version: 1.0 In-Reply-To: <20170104181314.4f9a0c40@bbrezillon> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/04/2017 06:13 PM, Boris Brezillon wrote: > On Wed, 4 Jan 2017 16:15:46 +0100 > Marek Vasut wrote: > >> On 01/03/2017 02:01 PM, Boris Brezillon wrote: >>> Move Micron specific initialization logic into nand_micron.c. This is >>> part of the "separate vendor specific code from core" cleanup process. >>> >>> Signed-off-by: Boris Brezillon >> >> [...] >> >>> diff --git a/drivers/mtd/nand/nand_micron.c b/drivers/mtd/nand/nand_micron.c >>> new file mode 100644 >>> index 000000000000..ddb9adf12c21 >>> --- /dev/null >>> +++ b/drivers/mtd/nand/nand_micron.c >>> @@ -0,0 +1,83 @@ >>> +/* >>> + * Copyright (C) 2013 Boris Brezillon >> >> 2013-2017 ? > > 2017, indeed. > >> >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License as published by >>> + * the Free Software Foundation; either version 2 of the License, or >>> + * (at your option) any later version. >>> + * >>> + * This program is distributed in the hope that it will be useful, >>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>> + * GNU General Public License for more details. >>> + */ >>> + >>> +#include >>> + >>> +struct nand_onfi_vendor_micron { >>> + u8 two_plane_read; >>> + u8 read_cache; >>> + u8 read_unique_id; >>> + u8 dq_imped; >>> + u8 dq_imped_num_settings; >>> + u8 dq_imped_feat_addr; >>> + u8 rb_pulldown_strength; >>> + u8 rb_pulldown_strength_feat_addr; >>> + u8 rb_pulldown_strength_num_settings; >>> + u8 otp_mode; >>> + u8 otp_page_start; >>> + u8 otp_data_prot_addr; >>> + u8 otp_num_pages; >>> + u8 otp_feat_addr; >>> + u8 read_retry_options; >>> + u8 reserved[72]; >>> + u8 param_revision; >>> +} __packed; >> >> Is this __packed really needed? >> > > I'm just copying an existing structure. And yes, it's probably unneeded > since all fields are u8, and the struct size in a multiple of 8 bytes, > but it shouldn't hurt either. > Could you send a patch to drop it, please ? :) -- Best regards, Marek Vasut