Re: [PATCH] mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver

Brian Norris
2012-07-17T06:27:17Z

Bump.

On Fri, Jul 13, 2012 at 7:02 PM, Huang Shijie <shijie8@gmail.com> wrote:
> On Fri, Jul 13, 2012 at 12:28 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
>> The NAND_CHIPOPTIONS_MSK has limited utility and is causing real bugs. It
>> silently masks off at least one flag that might be set by the driver
>> (NAND_NO_SUBPAGE_WRITE). This breaks the GPMI NAND driver and possibly
>> others.
>>
>> Really, as long as driver writers exercise a small amount of care with
>> NAND_* options, this mask is not necessary at all; it was only here to
>> prevent certain options from accidentally being set by the driver. But the
>> original thought turns out to be a bad idea occasionally. Thus, kill it.
>>
>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>> Cc: Huang Shijie <shijie8@gmail.com>
>> Cc: Marek Vasut <marex@denx.de>
>> ---
>> Huang, please test this with your driver.
>>
> I tested this patch on imx6q-arm2 board with Micron MT29F32G08QAA.
> it works fine, thanks.
>
> Tested-by: Huang Shijie <shijie8@gmail.com>

Any other Acks? Or acceptance from Artem/David?

Brian