From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <50126BC4.2010709@freescale.com> Date: Fri, 27 Jul 2012 18:21:56 +0800 From: Huang Shijie MIME-Version: 1.0 To: Dirk Behme Subject: Re: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA References: <1343215100-24005-1-git-send-email-festevam@gmail.com> <1343215100-24005-3-git-send-email-festevam@gmail.com> <50125FC3.4040603@de.bosch.com> In-Reply-To: <50125FC3.4040603@de.bosch.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Cc: Fabio Estevam , Fabio Estevam , Richard Zhao , "kernel@pengutronix.de" , "Artem.Bityutskiy@linux.intel.com" , "linux-mtd@lists.infradead.org" , "shawn.guo@linaro.org" , Huang Shijie , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , =E4=BA=8E 2012=E5=B9=B407=E6=9C=8827=E6=97=A5 17:30, Dirk Behme =E5=86=99= =E9=81=93: > On 26.07.2012 13:32, Huang Shijie wrote: >> On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam =20 >> wrote: >>> On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie =20 >>> wrote: >>>> On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam =20 >>>> wrote: >>>>> On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie =20 >>>>> wrote: >>>>> >>>>>> But you have added "depend on MXS_DMA". So If you do not select th= e >>>>>> mxs-dma, you can not see the >>>>>> gpmi-nand. >>>>>> that's why i think this patch is not needed. >>>>> So how CONFIG_MXS_DMA would be selected if not via defconfig? >>>> Use the make menuconfig ARCH=3Darm: >>>> >>>> "device drivers"-->"DMA engine support" -->"mxs dma support" >>> I prefer to have selected in the defconfig by default instead. >>> >>> It is not obvious for the end user that they need to manually select >>> this option. >>> >>> mxs_defconfig also selects CONFIG_MXS_DMA. >> In mx23/mx28, the mxs-dma has many users, so it's proper to make it=20 >> default. >> >>> Can't we do the same here and let imx_v6_v7_defconfig be built again? >> Shawn, do you have any opinion about this? > > First, I think Shawn is on holiday at the moment. > > Second, recent kernel mainline from today building imx_v6_v7_defconfig=20 > is broken due to this. Sascha did not CC to me when he submitted the patch 3def84ed9 "ARM:=20 imx_v6_v7_defconfig: ..". I would check this patch if he CCed to me. BR Huang Shijie > > So to make it build again, we have to enable CONFIG_MXS_DMA anyhow. As=20 > it seems that GPMI_NAND needs it to build, I would vote for the > > depends on MXS_DMA > > fix proposed by Richard > > http://www.spinics.net/lists/arm-kernel/msg186111.html > > Anyhow, any chance to get the kernel mainline fixed asap? > > Many thanks and best regards > > Dirk > >