* Re: [GIT PULL] ARM: LPC32xx: core update
[not found] ` <201209131155.16756.arnd@arndb.de>
@ 2012-09-14 9:52 ` Roland Stigge
2012-09-26 8:24 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Roland Stigge @ 2012-09-14 9:52 UTC (permalink / raw)
To: Arnd Bergmann
Cc: artem.bityutskiy, arm, Linux MTD,
linux-arm-kernel@lists.infradead.org
Hi Arnd,
On 13/09/12 13:55, Arnd Bergmann wrote:
> On Thursday 06 September 2012, Roland Stigge wrote:
>> ARM: LPC32xx: Provide DMA filter callbacks via platform data
>
> This patch results in build errors in the for-next branch with lpc32xx_defconfig:
>
> arch/arm/mach-lpc32xx/phy3250.c:40:35: fatal error: linux/mtd/lpc32xx_slc.h: No such file or directory
> arch/arm/mach-lpc32xx/phy3250.c:41:35: fatal error: linux/mtd/lpc32xx_mlc.h: No such file or directory
> arch/arm/mach-lpc32xx/phy3250.c:226:15: error: variable 'lpc32xx_slc_data' has initializer but incomplete type
> arch/arm/mach-lpc32xx/phy3250.c:227:2: error: unknown field 'dma_filter' specified in initializer
> arch/arm/mach-lpc32xx/phy3250.c:227:2: error: excess elements in struct initializer [-Werror]
> arch/arm/mach-lpc32xx/phy3250.c:227:2: error: (near initialization for 'lpc32xx_slc_data') [-Werror]
> arch/arm/mach-lpc32xx/phy3250.c:230:15: error: variable 'lpc32xx_mlc_data' has initializer but incomplete type
> arch/arm/mach-lpc32xx/phy3250.c:231:2: error: unknown field 'dma_filter' specified in initializer
> arch/arm/mach-lpc32xx/phy3250.c:231:2: error: excess elements in struct initializer [-Werror]
> arch/arm/mach-lpc32xx/phy3250.c:231:2: error: (near initialization for 'lpc32xx_mlc_data') [-Werror]
>
> It seems that we're missing a dependency. Which tree did the patch to add
> these go through? Can we add that to the same branch in arm-soc?
Right - there is a dependency on l2-mtd.git here.
Since they didn't request pull for 3.6, there is quite some stuff
pending in their tree (but I wonder why it isn't already part of
linux-next, so the above error at least shouldn't occur in linux-next).
So we have several alternative options here:
* If it is possible, include l2-mtd.git as a dependency in arm-soc.git
* Merge the following 2 patches as minimal dependency:
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commitdiff/c47bc5c84a65c31f41a555706363f9e350ca6338
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commitdiff/f5e87dd7350c98a34aa7041264c337f0f33c02ff
You actually only need the two .h files, ignore the patches for yet
non-existing .c mtd driver files in arm-soc.git.
* Defer the above (single) patch in arm-soc until l2-mtd is merged
linux-next or mainline. Maybe l2-mtd.git will appear in linux-next soon,
otherwise we will need to defer the above patch for lpc32xx/core for 3.8?
Sorry for the confusion,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] ARM: LPC32xx: core update
2012-09-14 9:52 ` [GIT PULL] ARM: LPC32xx: core update Roland Stigge
@ 2012-09-26 8:24 ` Artem Bityutskiy
2012-09-26 8:52 ` Roland Stigge
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2012-09-26 8:24 UTC (permalink / raw)
To: Roland Stigge
Cc: arm, Linux MTD, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 2918 bytes --]
On Fri, 2012-09-14 at 11:52 +0200, Roland Stigge wrote:
> Hi Arnd,
>
> On 13/09/12 13:55, Arnd Bergmann wrote:
> > On Thursday 06 September 2012, Roland Stigge wrote:
> >> ARM: LPC32xx: Provide DMA filter callbacks via platform data
> >
> > This patch results in build errors in the for-next branch with lpc32xx_defconfig:
> >
> > arch/arm/mach-lpc32xx/phy3250.c:40:35: fatal error: linux/mtd/lpc32xx_slc.h: No such file or directory
> > arch/arm/mach-lpc32xx/phy3250.c:41:35: fatal error: linux/mtd/lpc32xx_mlc.h: No such file or directory
> > arch/arm/mach-lpc32xx/phy3250.c:226:15: error: variable 'lpc32xx_slc_data' has initializer but incomplete type
> > arch/arm/mach-lpc32xx/phy3250.c:227:2: error: unknown field 'dma_filter' specified in initializer
> > arch/arm/mach-lpc32xx/phy3250.c:227:2: error: excess elements in struct initializer [-Werror]
> > arch/arm/mach-lpc32xx/phy3250.c:227:2: error: (near initialization for 'lpc32xx_slc_data') [-Werror]
> > arch/arm/mach-lpc32xx/phy3250.c:230:15: error: variable 'lpc32xx_mlc_data' has initializer but incomplete type
> > arch/arm/mach-lpc32xx/phy3250.c:231:2: error: unknown field 'dma_filter' specified in initializer
> > arch/arm/mach-lpc32xx/phy3250.c:231:2: error: excess elements in struct initializer [-Werror]
> > arch/arm/mach-lpc32xx/phy3250.c:231:2: error: (near initialization for 'lpc32xx_mlc_data') [-Werror]
> >
> > It seems that we're missing a dependency. Which tree did the patch to add
> > these go through? Can we add that to the same branch in arm-soc?
>
> Right - there is a dependency on l2-mtd.git here.
>
> Since they didn't request pull for 3.6, there is quite some stuff
> pending in their tree (but I wonder why it isn't already part of
> linux-next, so the above error at least shouldn't occur in linux-next).
It is in linux-next:
[dedekind@sauron linux-next (master)]$ git log --format='%h %an %s' drivers/mtd/ | grep Stigge
562dec8 Roland Stigge mtd: lpc32xx_mlc: Cleanup after DT-only conversion
ad978ee Roland Stigge mtd: lpc32xx_slc: Cleanup after DT-only conversion
7359e4c Roland Stigge mtd: lpc32xx_mlc: Make driver independent of AMBA DMA engine driver
fa5eae7 Roland Stigge mtd: lpc32xx_slc: Make driver independent of AMBA DMA engine driver
79f9df7 Roland Stigge mtd: lpc32xx_mlc: Adjust to pl08x DMA interface changes
314a156 Roland Stigge mtd: lpc32xx_slc: Adjust to pl08x DMA interface changes
70f7cb7 Roland Stigge mtd: add LPC32xx MLC NAND driver
d5842ab Roland Stigge mtd: lpc32xx_slc: Make probe() return -EPROBE_DEFER if necessary
21535ab Roland Stigge mtd: lpc32xx_slc: Use of_get_named_gpio()
2944a44 Roland Stigge mtd: add LPC32xx SLC NAND driver
9d7b4b5 Roland Stigge [MTD] [NAND] Fix refactoring of EDB7312 hwcontrol function.
4a32cfa Roland Stigge [MTD] [NAND] Fix refactoring of EDB7312 hwcontrol function.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [GIT PULL] ARM: LPC32xx: core update
2012-09-26 8:24 ` Artem Bityutskiy
@ 2012-09-26 8:52 ` Roland Stigge
0 siblings, 0 replies; 3+ messages in thread
From: Roland Stigge @ 2012-09-26 8:52 UTC (permalink / raw)
To: artem.bityutskiy
Cc: arm, Linux MTD, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann
On 09/26/2012 10:24 AM, Artem Bityutskiy wrote:
>> On 13/09/12 13:55, Arnd Bergmann wrote:
>>> On Thursday 06 September 2012, Roland Stigge wrote:
>>>> ARM: LPC32xx: Provide DMA filter callbacks via platform data
>>>
>>> This patch results in build errors in the for-next branch with
>>> lpc32xx_defconfig:
>>>
>>> arch/arm/mach-lpc32xx/phy3250.c:40:35: fatal error:
>>> linux/mtd/lpc32xx_slc.h: No such file or directory
>>> arch/arm/mach-lpc32xx/phy3250.c:41:35: fatal error:
>>> linux/mtd/lpc32xx_mlc.h: No such file or directory
>>> arch/arm/mach-lpc32xx/phy3250.c:226:15: error: variable
>>> 'lpc32xx_slc_data' has initializer but incomplete type
>>> arch/arm/mach-lpc32xx/phy3250.c:227:2: error: unknown field
>>> 'dma_filter' specified in initializer
>>> arch/arm/mach-lpc32xx/phy3250.c:227:2: error: excess elements
>>> in struct initializer [-Werror]
>>> arch/arm/mach-lpc32xx/phy3250.c:227:2: error: (near
>>> initialization for 'lpc32xx_slc_data') [-Werror]
>>> arch/arm/mach-lpc32xx/phy3250.c:230:15: error: variable
>>> 'lpc32xx_mlc_data' has initializer but incomplete type
>>> arch/arm/mach-lpc32xx/phy3250.c:231:2: error: unknown field
>>> 'dma_filter' specified in initializer
>>> arch/arm/mach-lpc32xx/phy3250.c:231:2: error: excess elements
>>> in struct initializer [-Werror]
>>> arch/arm/mach-lpc32xx/phy3250.c:231:2: error: (near
>>> initialization for 'lpc32xx_mlc_data') [-Werror]
>>>
>>> It seems that we're missing a dependency. Which tree did the
>>> patch to add these go through? Can we add that to the same
>>> branch in arm-soc?
>>
>> Right - there is a dependency on l2-mtd.git here.
>>
>> Since they didn't request pull for 3.6, there is quite some
>> stuff pending in their tree (but I wonder why it isn't already
>> part of linux-next, so the above error at least shouldn't occur
>> in linux-next).
>
> It is in linux-next:
>
> [dedekind@sauron linux-next (master)]$ git log --format='%h %an %s'
> drivers/mtd/ | grep Stigge 562dec8 Roland Stigge mtd: lpc32xx_mlc:
> Cleanup after DT-only conversion ad978ee Roland Stigge mtd:
> lpc32xx_slc: Cleanup after DT-only conversion 7359e4c Roland Stigge
> mtd: lpc32xx_mlc: Make driver independent of AMBA DMA engine
> driver fa5eae7 Roland Stigge mtd: lpc32xx_slc: Make driver
> independent of AMBA DMA engine driver 79f9df7 Roland Stigge mtd:
> lpc32xx_mlc: Adjust to pl08x DMA interface changes 314a156 Roland
> Stigge mtd: lpc32xx_slc: Adjust to pl08x DMA interface changes
> 70f7cb7 Roland Stigge mtd: add LPC32xx MLC NAND driver d5842ab
> Roland Stigge mtd: lpc32xx_slc: Make probe() return -EPROBE_DEFER
> if necessary 21535ab Roland Stigge mtd: lpc32xx_slc: Use
> of_get_named_gpio() 2944a44 Roland Stigge mtd: add LPC32xx SLC NAND
> driver 9d7b4b5 Roland Stigge [MTD] [NAND] Fix refactoring of
> EDB7312 hwcontrol function. 4a32cfa Roland Stigge [MTD] [NAND] Fix
> refactoring of EDB7312 hwcontrol function.
Good, thanks! Then, the above issue should be gone now.
Please note that there is still the dependency of mtd on mach-lpc32xx.
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-26 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50488FD6.4080402@antcom.de>
[not found] ` <201209131155.16756.arnd@arndb.de>
2012-09-14 9:52 ` [GIT PULL] ARM: LPC32xx: core update Roland Stigge
2012-09-26 8:24 ` Artem Bityutskiy
2012-09-26 8:52 ` Roland Stigge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).