From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-da0-f49.google.com ([209.85.210.49])
 by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux))
 id 1TLyWL-0006TD-52
 for linux-mtd@lists.infradead.org; Wed, 10 Oct 2012 15:48:30 +0000
Received: by mail-da0-f49.google.com with SMTP id q27so252085daj.36
 for <linux-mtd@lists.infradead.org>; Wed, 10 Oct 2012 08:48:25 -0700 (PDT)
Message-ID: <507598A4.8000704@gmail.com>
Date: Wed, 10 Oct 2012 21:17:48 +0530
From: Vikram Narayanan <vikram186@gmail.com>
MIME-Version: 1.0
To: dedekind1@gmail.com
Subject: Re: [PATCH] mtd: mtd_oobtest: printk -> pr_{info,err}
References: <1348713422-16626-1-git-send-email-computersforpeace@gmail.com>
 <1349880023.20594.36.camel@sauron.fi.intel.com>
In-Reply-To: <1349880023.20594.36.camel@sauron.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Brian Norris <computersforpeace@gmail.com>, linux-mtd@lists.infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On 10/10/2012 8:10 PM, Artem Bityutskiy wrote:
> On Wed, 2012-09-26 at 19:37 -0700, Brian Norris wrote:
>> Use pr_info() and pr_err() while defining pr_fmt(). This saves a few
>> characters, joins a few lines, and makes the code a little more readable
>> (and grep-able).
>>
>> Signed-off-by: Brian Norris<computersforpeace@gmail.com>
>
> Not sure about this - there is a patch-set from Vikram Narayanan
> <vikram186@gmail.com>  (Subject: [RFC PATCH 0/8] mtd_tests: Remove
> duplicate code and cleanups) which does this for all tests. I hoped he
> can re-send newer version.

Yeah. I'll send a newer version which will change the printk to pr_* for 
all the tests. I can take Brian's patch as well and send the whole 
series, if he is ok with it.

Regards,
Vikram