From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Afzal Mohammed <afzal@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"dedekind1@gmail.com" <dedekind1@gmail.com>
Subject: Re: [PATCH 1/3] omap gpmc : add support of setting CYCLE2CYCLEDELAY and BUSTURNAROUND
Date: Tue, 6 Nov 2012 19:00:42 +0100 [thread overview]
Message-ID: <5099504A.5060505@parrot.com> (raw)
In-Reply-To: <5099478A.50901@ti.com>
Jon Hunter a écrit :
> On 11/06/2012 10:44 AM, Matthieu CASTET wrote:
>>
>> /* caller is expected to have initialized CONFIG1 to cover
>> * at least sync vs async
>> diff --git a/arch/arm/plat-omap/include/plat/gpmc.h b/arch/arm/plat-omap/include/plat/gpmc.h
>> index 2e6e259..34ca454 100644
>> --- a/arch/arm/plat-omap/include/plat/gpmc.h
>> +++ b/arch/arm/plat-omap/include/plat/gpmc.h
>> @@ -131,6 +131,8 @@ struct gpmc_timings {
>> /* The following are only on OMAP3430 */
>> u16 wr_access; /* WRACCESSTIME */
>> u16 wr_data_mux_bus; /* WRDATAONADMUXBUS */
>> + u16 cycle2cycledelay; /* CYCLE2CYCLEDELAY */
>> + u16 busturnaround; /* BUSTURNAROUND */
>
> So you should be able to move these out of OMAP3430 specific as they are
> generic.
Thanks for the quick review.
I will post another patch, unless this is already done in Afzal patch (Is there
a tree where I can get Afzal pending patches ?)
Matthieu
next prev parent reply other threads:[~2012-11-06 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 16:44 [PATCH 1/3] omap gpmc : add support of setting CYCLE2CYCLEDELAY and BUSTURNAROUND Matthieu CASTET
2012-11-06 16:44 ` [PATCH 2/3] mtd nand : get timings from onfi Matthieu CASTET
2012-11-06 16:44 ` [PATCH 3/3] omap nand : use onfi mode to compute optimized timings Matthieu CASTET
2012-11-06 17:23 ` [PATCH 1/3] omap gpmc : add support of setting CYCLE2CYCLEDELAY and BUSTURNAROUND Jon Hunter
2012-11-06 18:00 ` Matthieu CASTET [this message]
2012-11-06 20:34 ` Jon Hunter
2012-11-07 8:58 ` Mohammed, Afzal
2012-11-07 21:40 ` Tony Lindgren
2012-11-08 12:54 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5099504A.5060505@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=afzal@ti.com \
--cc=dedekind1@gmail.com \
--cc=jon-hunter@ti.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox