From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.newsguy.com ([74.209.136.69])
 by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux))
 id 1TdPcc-0003Vw-GL
 for linux-mtd@lists.infradead.org; Tue, 27 Nov 2012 18:11:03 +0000
Message-ID: <50B5024C.3030907@newsguy.com>
Date: Tue, 27 Nov 2012 10:11:24 -0800
From: Mike Dunn <mikedunn@newsguy.com>
MIME-Version: 1.0
To: Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH] mtd cs553x_nand: Initialise ecc.strength before
 nand_scan()
References: <1353541372.12585.14.camel@laptop>
 <CAN8TOE-10VYTOS8EbPWxs0HyhdeZBzxL_8gmJsMmXPO1ti_6bQ@mail.gmail.com>
In-Reply-To: <CAN8TOE-10VYTOS8EbPWxs0HyhdeZBzxL_8gmJsMmXPO1ti_6bQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Nathan Williams <nathan@traverse.com.au>,
 "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Artem Bityutskiy <dedekind1@gmail.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On 11/21/2012 08:08 PM, Brian Norris wrote:
> On Wed, Nov 21, 2012 at 3:42 PM, Nathan Williams <nathan@traverse.com.au> wrote:
>> Loading cs553x_nand with Hynix H27U1G8F2BTR NAND flash causes this bug:
>>
>> kernel BUG at drivers/mtd/nand/nand_base.c:3345!
> ...
>> Initialising ecc.strength before the call to nand_scan() fixes this.
> 
> Acked-by: Brian Norris <computersforpeace@gmail.com>


Acked-by: Mike Dunn <mikedunn@newsguy.com>


> 
> BTW, I made a quick read through of the other NAND drivers to look for
> similar errors. I think this is the only one where the only
> ecc.strenght initialization occurred after the nand_scan() or
> nand_scan_tail() call.


Thanks for that Brian.  I thought I did this when another driver had a similiar
problem a while back.  Maybe I just intended to :(

Mike