From: Zach Sadecki <zsadecki@itwatchdogs.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: UBI Fastmap fixes for 3.7
Date: Tue, 4 Dec 2012 08:45:18 -0600 [thread overview]
Message-ID: <50BE0C7E.6000001@itwatchdogs.com> (raw)
In-Reply-To: <1354564667-9549-1-git-send-email-richard@nod.at>
On 12/03/2012 01:57 PM, Richard Weinberger wrote:
> This patch series contains two brown-paper-bag-bugfixes.
> I'm very sorry for them!
>
> [PATCH 1/2] ubi: Remove PEB from free tree in get_peb_for_wl()
> This one fixes a very odd issue with fastmap disabled.
> With fastmap disabled get_peb_for_wl() did not remove PEBs from
> the free list. Therefore the free, used and scrub trees got corrupted.
>
> [PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb()
> The issue fixed by that patch is also very nasty. I missed that
> ubi_self_check_all_ff() can sleep. So, we cannot call it from
> __wl_get_peb().
>
> Thanks,
> //richard
Thanks, guys. An overnight test run has shown that these patches have
fixed the UBI problems on my board. Something else odd is happening,
but that's for another thread...
next prev parent reply other threads:[~2012-12-04 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 15:05 UBI wl_tree_add problems after PEB scrubbed Zach Sadecki
2012-12-03 10:48 ` Artem Bityutskiy
2012-12-03 11:01 ` Artem Bityutskiy
2012-12-03 11:19 ` Richard Weinberger
2012-12-03 14:46 ` Artem Bityutskiy
2012-12-03 15:02 ` Richard Weinberger
2012-12-03 15:33 ` Artem Bityutskiy
[not found] ` <1354564667-9549-1-git-send-email-richard@nod.at>
2012-12-03 19:57 ` [PATCH 1/2] ubi: Remove PEB from free tree in get_peb_for_wl() Richard Weinberger
2012-12-04 8:34 ` Artem Bityutskiy
2012-12-04 10:24 ` Richard Weinberger
2012-12-03 19:57 ` [PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb() Richard Weinberger
2012-12-04 7:55 ` Artem Bityutskiy
2012-12-04 7:56 ` Artem Bityutskiy
2012-12-04 8:15 ` Artem Bityutskiy
2012-12-04 9:15 ` Richard Weinberger
2012-12-04 14:45 ` Zach Sadecki [this message]
2012-12-04 14:48 ` UBI Fastmap fixes for 3.7 Richard Weinberger
2012-12-04 14:56 ` Zach Sadecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BE0C7E.6000001@itwatchdogs.com \
--to=zsadecki@itwatchdogs.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox