From: Sekhar Nori <nsekhar@ti.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-mtd@lists.infradead.org,
davinci-linux-open-source@linux.davincidsp.com, hs@denx.de,
dwmw2@infradead.org
Subject: Re: [PATCH v2] davinci_nand: fix modular build with CONFIG_OF=y
Date: Fri, 4 Jan 2013 11:22:26 +0530 [thread overview]
Message-ID: <50E66E1A.80307@ti.com> (raw)
In-Reply-To: <201301032127.34467.sshtylyov@ru.mvista.com>
Hi Sergei,
On 1/3/2013 11:57 PM, Sergei Shtylyov wrote:
> Commit cdeadd712f52b16a9285386d61ee26fd14eb4085 (mtd: nand: davinci: add OF
> support for davinci nand controller) has never been really build tested with
> the driver as a module. When the driver is built-in, the missing semicolon
> after structure initializer is "compensated" by MODULE_DEVICE_TABLE() macro
> being empty and so the initializer using the trailing semicolon on the next
> line; when the driver is built as a module, compilation error ensues, and as
> the 'davinci_all_defconfig' has the NAND driver modular, this error prevents
> DaVinci family kernel from building...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Cc: stable@vger.kernel.org # 3.7
>
> ---
> The patch is atop of the recent Linus' tree.
> Sekhar, have you build tested at least 3.8-rc1?
v3.8-rc2 builds and boots fine. 'make modules' needs your patch, of
course. For this patch, FWIW:
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2013-01-04 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 18:27 [PATCH v2] davinci_nand: fix modular build with CONFIG_OF=y Sergei Shtylyov
2013-01-04 5:52 ` Sekhar Nori [this message]
2013-01-04 6:40 ` Heiko Schocher
2013-01-11 17:44 ` Sergei Shtylyov
2013-01-11 16:54 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E66E1A.80307@ti.com \
--to=nsekhar@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dwmw2@infradead.org \
--cc=hs@denx.de \
--cc=linux-mtd@lists.infradead.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox